Skip to content

Test: Check existing multi language support #22593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented May 16, 2025

status :testing
closes #22608

Testing Steps: Shake device -> Language -> Select language -> Restart

Video:

signal-2025-05-16-152516.mp4

@Parveshdhull Parveshdhull self-assigned this May 16, 2025
@status-github-bot-v2 status-github-bot-v2 bot moved this to CONTRIBUTOR in Pipeline for QA May 16, 2025
@status-im-auto
Copy link
Member

status-im-auto commented May 16, 2025

Jenkins Builds

Click to see older builds (5)
Commit #️⃣ Finished (UTC) Duration Platform Result
e10004d #1 2025-05-16 08:41:59 ~2 min tests 📄log
✔️ e10004d #1 2025-05-16 08:47:24 ~8 min android-e2e 🤖apk 📲
✔️ e10004d #1 2025-05-16 08:48:00 ~8 min android 🤖apk 📲
✔️ e10004d #1 2025-05-16 08:53:16 ~14 min ios 📱ipa 📲
84122a9 #2 2025-05-16 09:31:48 ~3 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
5f6add4 #3 2025-05-16 09:37:15 ~3 min tests 📄log
✔️ 5f6add4 #3 2025-05-16 09:40:41 ~7 min android-e2e 🤖apk 📲
✔️ 5f6add4 #3 2025-05-16 09:41:39 ~8 min android 🤖apk 📲
✔️ 103b896 #4 2025-05-16 09:48:21 ~4 min tests 📄log
✔️ 103b896 #4 2025-05-16 09:50:40 ~6 min android-e2e 🤖apk 📲
✔️ 103b896 #4 2025-05-16 09:52:57 ~9 min android 🤖apk 📲
✔️ 103b896 #4 2025-05-16 09:54:11 ~10 min ios 📱ipa 📲

@Parveshdhull Parveshdhull force-pushed the test/support-multi-language branch 2 times, most recently from 84122a9 to 5f6add4 Compare May 16, 2025 09:32
@Parveshdhull Parveshdhull force-pushed the test/support-multi-language branch from 5f6add4 to 103b896 Compare May 16, 2025 09:43
@ilmotta
Copy link
Contributor

ilmotta commented May 19, 2025

Thanks @Parveshdhull! I tested the build with Spanish and Portuguese (Brazil). Although far from good, it's motivating to see us adding back multilingual support! A few notes:

  • There are many missing translations, but that's expected.
  • Some translations need more context. For example, the translation key all is set to Todos (referring to all notifications in the AC), but it should use Todas because in both languages we refer to notifications in the feminine. This means that we should probably avoid keys that have too little context. A better key in the JSON files would be all_notifications to give the translator (human or LLM) enough context.
    • Definitely something that will require careful manual review and the reason why we should add one language at a time, otherwise it looks quite unprofessional to see obviously wrong translations.
    • Crowdin has support for the ICU syntax, but we should likely avoid any changes to the format of our translations.
  • Since we are talking about adding support for Spanish, we should simplify and remove all specialized es_* files in the repo and focus only in one Spanish locale es.
    • Our efforts should focus on adding more languages instead of variations of the same language, at least until we reach our desired goal of translating the most commonly used languages according to our metrics in app stores.
  • Our translation linter may help us delete more unused keys, although it does require double-checking because of false positives.

I'm curious to see the quality of results from an LLM pass on the en.json file to es.json. Definitely won't be great, but curious nonetheless :)

@github-project-automation github-project-automation bot moved this from CONTRIBUTOR to DONE in Pipeline for QA May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

Restore locale-based language loading using translations/ folder
3 participants