Skip to content

Commit fc48cc2

Browse files
committed
Remove duplicate notification dot on sidebar buttons on mobile
1 parent 7e7da64 commit fc48cc2

File tree

1 file changed

+4
-6
lines changed
  • code/core/src/manager/components/sidebar

1 file changed

+4
-6
lines changed

code/core/src/manager/components/sidebar/Menu.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,7 @@ export const SidebarMenu: FC<SidebarMenuProps> = ({ menu, isHighlighted, onClick
8383
<SidebarIconButton
8484
title="About Storybook"
8585
aria-label="About Storybook"
86-
// @ts-expect-error (non strict)
87-
highlighted={isHighlighted}
86+
highlighted={!!isHighlighted}
8887
active={false}
8988
// @ts-expect-error (non strict)
9089
onClick={onClick}
@@ -95,8 +94,7 @@ export const SidebarMenu: FC<SidebarMenuProps> = ({ menu, isHighlighted, onClick
9594
<SidebarIconButton
9695
title="Close menu"
9796
aria-label="Close menu"
98-
// @ts-expect-error (non strict)
99-
highlighted={isHighlighted}
97+
highlighted={false}
10098
active={false}
10199
onClick={() => setMobileMenuOpen(false)}
102100
isMobile={true}
@@ -117,10 +115,10 @@ export const SidebarMenu: FC<SidebarMenuProps> = ({ menu, isHighlighted, onClick
117115
<SidebarIconButton
118116
title="Shortcuts"
119117
aria-label="Shortcuts"
120-
// @ts-expect-error (non strict)
121-
highlighted={isHighlighted}
118+
highlighted={!!isHighlighted}
122119
active={isTooltipVisible}
123120
size="medium"
121+
isMobile={false}
124122
>
125123
<CogIcon />
126124
</SidebarIconButton>

0 commit comments

Comments
 (0)