Skip to content

Task: Update bench-package script message when a report can't be produced #31582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yannbf opened this issue May 27, 2025 · 0 comments
Open

Task: Update bench-package script message when a report can't be produced #31582

yannbf opened this issue May 27, 2025 · 0 comments
Assignees
@JReinhold
Labels
build Internal-facing build tooling & test updates

Comments

@yannbf
Copy link
Member

yannbf commented May 27, 2025 •
edited
Loading

Describe the bug

When making a PR from some-feature-branch <- extra-fixes and the base branch does not have a baseline report, the script should only report a message like:

“no bench results found on the base branch (some-feature-branch), ”.

So we avoid misleading messages such as:

Image
@yannbf yannbf added the build Internal-facing build tooling & test updates label May 27, 2025
@yannbf yannbf changed the title [Bug]: Update bench-package script message when a report can't be produced Task: Update bench-package script message when a report can't be produced May 27, 2025
@yannbf yannbf moved this to Empathy Backlog in Core Team Projects May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JReinhold JReinhold

Labels
build Internal-facing build tooling & test updates
Projects
Core Team Projects
Status: Empathy Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yannbf @JReinhold