Skip to content

rspack: ES codegen that modifies span to emulate codegen + reparse #9976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kdy1 opened this issue Jan 29, 2025 · 1 comment · May be fixed by #10349
Open

rspack: ES codegen that modifies span to emulate codegen + reparse #9976

kdy1 opened this issue Jan 29, 2025 · 1 comment · May be fixed by #10349
Assignees
@kdy1
Milestone
Planned

Comments

@kdy1
Copy link
Member

kdy1 commented Jan 29, 2025

This is to remove the need to parse again.
@kdy1 kdy1 added this to the Planned milestone Jan 29, 2025
@kdy1 kdy1 self-assigned this Jan 29, 2025
@kdy1 kdy1 mentioned this issue Jan 29, 2025
Closed
@kdy1
Copy link
Member Author

kdy1 commented Feb 19, 2025 •
edited
Loading

I found that it's not possible to easyly implement it from swc_ecma_codegen because the Emitter does not write to String directly. The Emiiter cannot know the exact output position of the text it send to the JsWriter

@kdy1 kdy1 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2025
@kdy1 kdy1 reopened this Feb 19, 2025
@kdy1 kdy1 mentioned this issue Mar 24, 2025
Closed
@kdy1 kdy1 linked a pull request Apr 10, 2025 that will close this issue
Draft
@kdy1 kdy1 modified the milestones: Planned, v1.11.26 May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdy1 kdy1

Labels
None yet
Milestone
Planned
1 participant
@kdy1