Skip to content

es/codegen: commit_pending_semi should be explicit #9937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kdy1 opened this issue Jan 23, 2025 · 0 comments · May be fixed by #9941
Open

es/codegen: commit_pending_semi should be explicit #9937

kdy1 opened this issue Jan 23, 2025 · 0 comments · May be fixed by #9941
Milestone
Planned

Comments

@kdy1
Copy link
Member

kdy1 commented Jan 23, 2025

swc/crates/swc_ecma_codegen/src/text_writer/semicolon.rs

Lines 70 to 73 in 8fc7700

match s {
"\"" | "'" | "[" | "!" | "/" | "{" | "(" | "~" | "-" | "+" | "#" | "`" | "*" => {
self.commit_pending_semi()?;
}

This results in [u8]::eq calls.
@kdy1 kdy1 linked a pull request Jan 24, 2025 that will close this issue
Draft
@kdy1 kdy1 added this to the Planned milestone Jan 24, 2025
@kdy1 kdy1 changed the title swc_ecma_codegen should invoke commit_pending_semi explicitly swc_ecma_codegen: commit_pending_semi should be explicit Jan 26, 2025
@kdy1 kdy1 changed the title swc_ecma_codegen: commit_pending_semi should be explicit es/codegen: commit_pending_semi should be explicit Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
Planned
Development

Successfully merging a pull request may close this issue.

perf(es/codegen): Remove needless string comparison kdy1/swc
1 participant
@kdy1