node.js - upgrade node.js to v23.5.0 (#9412)

Author: GiladShoham

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2.1
 
 default_image: &default_image
   docker:
-    - image: cimg/node:22.12.0
+    - image: cimg/node:23.5.0
 
 default_resource_class: &default_resource_class
   resource_class: medium
@@ -87,7 +87,7 @@ commands: # reusable commands
         default: 'BASE_IMAGE'
         type: string
       docker_build_arg_value:
-        default: 'node:22.12.0'
+        default: 'node:23.5.0'
         type: string
       image_name:
         default: 'bitcli/bit'
@@ -116,7 +116,7 @@ commands: # reusable commands
         default: 'BASE_IMAGE'
         type: string
       docker_build_arg_value:
-        default: 'node:22.12.0'
+        default: 'node:23.5.0'
         type: string
       image_name:
         default: 'bitcli/bit'
@@ -198,13 +198,13 @@ commands: # reusable commands
   windows_set_node_version:
     parameters:
       version:
-        default: 22.12.0
+        default: 23.5.0
         type: string
     steps:
       - run: choco upgrade nvm -y
       - run: nvm -v
-      - run: nvm install 22.12.0
-      - run: nvm use 22.12.0
+      - run: nvm install 23.5.0
+      - run: nvm use 23.5.0
       - run: node -v
   windows_add_bvm_to_path:
     steps:
@@ -272,8 +272,8 @@ jobs:
       - attach_workspace:
           at: ./
       - docker_build_and_push:
-          docker_build_arg_value: "node:22.12.0"
-          docker_tag_suffix: "-node-22.12.0"
+          docker_build_arg_value: "node:23.5.0"
+          docker_tag_suffix: "-node-23.5.0"
 
   # docker_non_root_build:
   #   machine:
@@ -292,10 +292,10 @@ jobs:
       - attach_workspace:
           at: ./
       - docker_build_and_push:
-          docker_build_arg_value: "node:22.12.0"
+          docker_build_arg_value: "node:23.5.0"
           image_name: "bitcli/bit-non-root"
           docker_file_name: "Dockerfile-bit-non-root"
-          docker_tag_suffix: "-node-22.12.0"
+          docker_tag_suffix: "-node-23.5.0"
 
 
   server_docker_build_node_22:
@@ -306,10 +306,10 @@ jobs:
           at: ./
       - docker_build_and_push:
           docker_build_arg_name: "BIT_IMAGE"
-          docker_build_arg_value: "`npm show @teambit/bit version`-node-22.12.0"
+          docker_build_arg_value: "`npm show @teambit/bit version`-node-23.5.0"
           image_name: "bitcli/bit-server"
           docker_file_name: "Dockerfile-bit-server"
-          docker_tag_suffix: "-node-22.12.0"
+          docker_tag_suffix: "-node-23.5.0"
   set_ssh_key:
     <<: *defaults
     working_directory: ~/.ssh
@@ -905,9 +905,9 @@ jobs:
       # - run: node -v
       # - run: npm -v
       # - run: yarn -v
-      # # - run: choco install nodejs --version 22.12.0
+      # # - run: choco install nodejs --version 23.5.0
       # # - run: node -v
-      # - run: cinst nodejs --version 22.12.0
+      # - run: cinst nodejs --version 23.5.0
       # - run: node -v
 
   windows_checkout_code:

scopes/harmony/bit/bootstrap.ts

@@ -8,8 +8,8 @@ import { GLOBAL_CONFIG, GLOBAL_LOGS } from '@teambit/legacy.constants';
 import { printWarning, shouldDisableConsole, shouldDisableLoader } from '@teambit/legacy.logger';
 import { loader } from '@teambit/legacy.loader';
 
-const RECOMMENDED_NODE_VERSIONS = '>=20.0.0 <23.0.0';
-const SUPPORTED_NODE_VERSIONS = '>=16.0.0 <23.0.0';
+const RECOMMENDED_NODE_VERSIONS = '>=20.0.0 <24.0.0';
+const SUPPORTED_NODE_VERSIONS = '>=16.0.0 <24.0.0';
 
 process.env.MEMFS_DONT_WARN = 'true'; // suppress fs experimental warnings from memfs
 

scripts/docker-teambit-bit/Dockerfile-bit

@@ -1,4 +1,4 @@
-ARG BASE_IMAGE=node:22.12.0
+ARG BASE_IMAGE=node:23.5.0
 FROM $BASE_IMAGE
 USER root
 

scripts/docker-teambit-bit/Dockerfile-bit-non-root

@@ -1,4 +1,4 @@
-ARG BASE_IMAGE=node:22.12.0
+ARG BASE_IMAGE=node:23.5.0
 FROM $BASE_IMAGE
 RUN adduser --disabled-password --gecos '' user
 RUN chown -R user /usr/local/

workspace.jsonc

@@ -639,7 +639,7 @@
       "encoding": "-"
     },
     "rootComponents": true,
-    "nodeVersion": "22.12.0",
+    "nodeVersion": "23.5.0",
     "engineStrict": true,
     // This is a temporary workaround to fix "bit compile" on macOS and Windows.
     // "bit compile" breaks node_modules when hard links are used.
@@ -721,7 +721,7 @@
         "packageJson": {
           "name": "@teambit/{name}", // @teambit/discovery.ui.sidebar
           "bvm": {
-            "node": "22.12.0"
+            "node": "23.5.0"
           },
           "bin": {
             "bbit": "bin/bit"