refactor, remove the legacy hooks (#9023)

Author: davidfirst

components/legacy/scope-api/lib/delete.ts

@@ -1,36 +1,26 @@
 import { ComponentIdList } from '@teambit/component-id';
-import { POST_REMOVE_REMOTE, PRE_REMOVE_REMOTE } from '@teambit/legacy/dist/constants';
-import HooksManager from '@teambit/legacy/dist/hooks';
 import { loadScope } from '@teambit/legacy/dist/scope';
 import RemovedObjects, { RemovedObjectSerialized } from '@teambit/legacy/dist/scope/removed-components';
 
-const HooksManagerInstance = HooksManager.getInstance();
-
-export default async function remove(
-  { path, ids, force, lanes }: { path: string; ids: string[]; force: boolean; lanes: boolean },
-  headers?: Record<string, any>
-): Promise<RemovedObjectSerialized> {
+export default async function remove({
+  path,
+  ids,
+  force,
+  lanes,
+}: {
+  path: string;
+  ids: string[];
+  force: boolean;
+  lanes: boolean;
+}): Promise<RemovedObjectSerialized> {
   const scope = await loadScope(path);
   if (lanes) {
     const removedLanes = await scope.lanes.removeLanes(scope, ids, force);
     const removedObjects = new RemovedObjects({ removedLanes });
     return removedObjects.serialize();
   }
   const bitIds = ComponentIdList.fromStringArray(ids);
-  const args = { path, bitIds, force };
   // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-  HooksManagerInstance?.triggerHook(PRE_REMOVE_REMOTE, args, headers);
   const res = await scope.removeMany(bitIds, force);
-  const hookArgs = {
-    removedComponentsIds: res.removedComponentIds.toStringArray(),
-    missingComponentsIds: res.missingComponents.toStringArray(),
-    dependentBitsIds: res.dependentBits,
-    force,
-    scopePath: path,
-    componentsIds: bitIds.toStringArray(),
-    scopeName: scope.scopeJson.name,
-  };
-  // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-  await HooksManagerInstance?.triggerHook(POST_REMOVE_REMOTE, hookArgs, headers);
   return res.serialize();
 }

components/legacy/scope-api/lib/fetch.ts

@@ -3,12 +3,10 @@ import Queue from 'p-queue';
 import { ComponentIdList } from '@teambit/component-id';
 import semver from 'semver';
 import { LaneId } from '@teambit/lane-id';
-import { LATEST_BIT_VERSION, POST_SEND_OBJECTS, PRE_SEND_OBJECTS } from '@teambit/legacy/dist/constants';
-import HooksManager from '@teambit/legacy/dist/hooks';
+import { LATEST_BIT_VERSION } from '@teambit/legacy/dist/constants';
 import logger from '@teambit/legacy/dist/logger/logger';
 import { loadScope, Scope } from '@teambit/legacy/dist/scope';
 import { Ref } from '@teambit/legacy/dist/scope/objects';
-import { ObjectList } from '@teambit/legacy/dist/scope/objects/object-list';
 import {
   ComponentWithCollectOptions,
   ObjectsReadableGenerator,
@@ -77,8 +75,6 @@ export type FETCH_OPTIONS = {
 
 export const CURRENT_FETCH_SCHEMA = '0.0.3';
 
-const HooksManagerInstance = HooksManager.getInstance();
-
 const openConnections: number[] = [];
 const openConnectionsMetadata: { [connectionId: string]: Record<string, any> } = {};
 let fetchCounter = 0;
@@ -141,12 +137,6 @@ fetchOptions`,
   if (fetchOptions.returnNothingIfGivenVersionExists) {
     fetchOptions.type = 'component-delta';
   }
-  const args = { path, ids, ...fetchOptions };
-  // This might be undefined in case of fork process like during bit test command
-  if (HooksManagerInstance) {
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-    HooksManagerInstance?.triggerHook(PRE_SEND_OBJECTS, args, headers);
-  }
   const fetchSchema = fetchOptions.fetchSchema || '0.0.1';
   const clientSupportsVersionHistory = semver.gte(fetchSchema, '0.0.2');
 
@@ -156,7 +146,6 @@ fetchOptions`,
   // memory consumption it causes as it caches many objects in-memory.
   const useCachedScope = true;
   const scope: Scope = await loadScope(path, useCachedScope);
-  const objectList = new ObjectList();
   const finishLog = (err?: Error) => {
     const duration = new Date().getTime() - startTime;
     openConnections.splice(openConnections.indexOf(currentFetch), 1);
@@ -175,20 +164,6 @@ took: ${duration} ms.`);
     finishLog(err);
     throw err;
   }
-
-  if (HooksManagerInstance) {
-    await HooksManagerInstance?.triggerHook(
-      POST_SEND_OBJECTS,
-      {
-        objectList,
-        scopePath: path,
-        ids,
-        scopeName: scope.scopeJson.name,
-      },
-      // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-      headers
-    );
-  }
   logger.debug('scope.fetch returns readable');
   return objectsReadableGenerator.readable;
 }

components/legacy/scope-api/lib/put.ts

@@ -1,13 +1,8 @@
-import R from 'ramda';
 import { ComponentIdList } from '@teambit/component-id';
-import { POST_RECEIVE_OBJECTS, PRE_RECEIVE_OBJECTS } from '@teambit/legacy/dist/constants';
-import HooksManager from '@teambit/legacy/dist/hooks';
 import { loadScope } from '@teambit/legacy/dist/scope';
 import { exportManyBareScope } from '@teambit/legacy/dist/scope/component-ops/export-scope-components';
 import { ObjectList } from '@teambit/legacy/dist/scope/objects/object-list';
 
-const HooksManagerInstance = HooksManager.getInstance();
-
 export type ComponentObjectsInput = {
   path: string;
   objectList: string | ObjectList;
@@ -18,16 +13,10 @@ export type PushOptions = {
   persist?: boolean; // persist the objects immediately with no validation. (for legacy and bit-sign).
 };
 
-export async function put(
-  { path, objectList }: ComponentObjectsInput,
-  pushOptions: PushOptions,
-  headers?: Record<string, any>
-): Promise<string[]> {
+export async function put({ path, objectList }: ComponentObjectsInput, pushOptions: PushOptions): Promise<string[]> {
   if (typeof objectList === 'string') {
     objectList = ObjectList.fromJsonString(objectList);
   }
-
-  await HooksManagerInstance?.triggerHook(PRE_RECEIVE_OBJECTS, { path, objectList }, headers);
   const scope = await loadScope(path);
   if (pushOptions && pushOptions.clientId) {
     // harmony
@@ -37,20 +26,6 @@ export async function put(
   // legacy client (non-harmony) or bit-sign.
   const componentsBitIds: ComponentIdList = await exportManyBareScope(scope, objectList);
   const componentsIds: string[] = componentsBitIds.map((id) => id.toString());
-  let uniqComponentsIds = componentsIds;
-  if (componentsIds && componentsIds.length) {
-    uniqComponentsIds = R.uniq(componentsIds);
-  }
-  await HooksManagerInstance?.triggerHook(
-    POST_RECEIVE_OBJECTS,
-    {
-      objectList,
-      componentsIds: uniqComponentsIds,
-      scopePath: path,
-      scopeName: scope.scopeJson.name,
-    },
-    // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!
-    headers
-  );
+
   return componentsIds;
 }

scopes/component/remove/remove-components.ts

@@ -6,7 +6,6 @@ import { ComponentIdList } from '@teambit/component-id';
 import { compact, isEmpty } from 'lodash';
 import { CENTRAL_BIT_HUB_NAME, CENTRAL_BIT_HUB_URL, LATEST_BIT_VERSION } from '@teambit/legacy/dist/constants';
 import { BitError } from '@teambit/bit-error';
-import enrichContextFromGlobal from '@teambit/legacy/dist/hooks/utils/enrich-context-from-global';
 import logger from '@teambit/legacy/dist/logger/logger';
 import { Http } from '@teambit/legacy/dist/scope/network/http';
 import { Remotes } from '@teambit/legacy/dist/remotes';
@@ -90,7 +89,6 @@ async function removeRemote(
     );
   }
   const context = {};
-  enrichContextFromGlobal(context);
   const removeP = Object.keys(groupedBitsByScope).map(async (key) => {
     const resolvedRemote = await remotes.resolve(key, workspace?.scope.legacyScope);
     const idsStr = groupedBitsByScope[key].map((id) => id.toStringWithoutVersion());

scopes/component/snapping/snapping.main.runtime.ts

@@ -6,10 +6,9 @@ import { WorkspaceAspect, OutsideWorkspaceError, Workspace } from '@teambit/work
 import semver, { ReleaseType } from 'semver';
 import { compact, difference, uniq } from 'lodash';
 import { ComponentID, ComponentIdList } from '@teambit/component-id';
-import { POST_TAG_ALL_HOOK, POST_TAG_HOOK, Extensions, LATEST, BuildStatus } from '@teambit/legacy/dist/constants';
+import { Extensions, LATEST, BuildStatus } from '@teambit/legacy/dist/constants';
 import { Consumer } from '@teambit/legacy/dist/consumer';
 import ComponentsList from '@teambit/legacy/dist/consumer/component/components-list';
-import HooksManager from '@teambit/legacy/dist/hooks';
 import pMapSeries from 'p-map-series';
 import loader from '@teambit/legacy/dist/cli/loader';
 import ComponentsPendingImport from '@teambit/legacy/dist/consumer/exceptions/components-pending-import';
@@ -62,8 +61,6 @@ import {
   removeLocalVersionsForMultipleComponents,
 } from './reset-component';
 
-const HooksManagerInstance = HooksManager.getInstance();
-
 export type TagDataPerComp = {
   componentId: ComponentID;
   dependencies: ComponentID[];
@@ -183,8 +180,6 @@ export class SnappingMain {
 
     const exactVersion = version;
     if (!this.workspace) throw new OutsideWorkspaceError();
-    const idsHasPattern = this.workspace.hasPattern(ids);
-    const isAll = Boolean(!ids.length || idsHasPattern);
     const validExactVersion = validateVersion(exactVersion);
     const consumer = this.workspace.consumer;
     const componentsList = new ComponentsList(consumer);
@@ -246,8 +241,6 @@ export class SnappingMain {
       removedComponents,
     };
 
-    const postHook = isAll ? POST_TAG_ALL_HOOK : POST_TAG_HOOK;
-    HooksManagerInstance?.triggerHook(postHook, tagResults);
     await consumer.onDestroy(`tag (message: ${message || 'N/A'})`);
     await stagedConfig?.write();
     // @ts-ignore AUTO-ADDED-AFTER-MIGRATION-PLEASE-FIX!

scopes/harmony/bit/bootstrap.ts

@@ -6,7 +6,6 @@ import { getBitVersionGracefully } from '@teambit/bit.get-bit-version';
 import { Analytics } from '@teambit/legacy.analytics';
 import { handleUnhandledRejection } from '@teambit/cli';
 import { BIT_VERSION, GLOBAL_CONFIG, GLOBAL_LOGS } from '@teambit/legacy/dist/constants';
-import HooksManager from '@teambit/legacy/dist/hooks';
 import { printWarning, shouldDisableConsole, shouldDisableLoader } from '@teambit/legacy/dist/logger/logger';
 import loader from '@teambit/legacy/dist/cli/loader';
 
@@ -37,7 +36,6 @@ export async function bootstrap() {
   verifyNodeVersionCompatibility();
   await ensureDirectories();
   await Analytics.promptAnalyticsIfNeeded();
-  HooksManager.init();
 }
 
 async function ensureDirectories() {

scopes/lanes/lanes/remove-lanes.ts

@@ -1,7 +1,6 @@
 import groupArray from 'group-array';
 import { LaneId } from '@teambit/lane-id';
 import { Consumer } from '@teambit/legacy/dist/consumer';
-import enrichContextFromGlobal from '@teambit/legacy/dist/hooks/utils/enrich-context-from-global';
 import { Remotes } from '@teambit/legacy/dist/remotes';
 import { getScopeRemotes } from '@teambit/legacy/dist/scope/scope-remotes';
 import { Http } from '@teambit/legacy/dist/scope/network/http';
@@ -31,7 +30,6 @@ async function removeRemoteLanes(consumer: Consumer | undefined, lanes: LaneId[]
     );
   }
   const context = {};
-  enrichContextFromGlobal(context);
   const groupedLanesByScope = groupArray(lanes, 'scope');
   const removeP = Object.keys(groupedLanesByScope).map(async (key) => {
     const resolvedRemote = await remotes.resolve(key, consumer?.scope);

scopes/scope/export/export.main.runtime.ts

@@ -10,16 +10,10 @@ import {
   BEFORE_EXPORTS,
   BEFORE_LOADING_COMPONENTS,
 } from '@teambit/legacy/dist/cli/loader/loader-messages';
-import {
-  CENTRAL_BIT_HUB_NAME,
-  CENTRAL_BIT_HUB_URL,
-  POST_EXPORT_HOOK,
-  PRE_EXPORT_HOOK,
-} from '@teambit/legacy/dist/constants';
+import { CENTRAL_BIT_HUB_NAME, CENTRAL_BIT_HUB_URL } from '@teambit/legacy/dist/constants';
 import { Consumer } from '@teambit/legacy/dist/consumer';
 import { BitMap } from '@teambit/legacy.bit-map';
 import ComponentsList from '@teambit/legacy/dist/consumer/component/components-list';
-import HooksManager from '@teambit/legacy/dist/hooks';
 import { RemoveAspect, RemoveMain } from '@teambit/remove';
 import { Lane, ModelComponent, Symlink, Version } from '@teambit/legacy/dist/scope/models';
 import { hasWildcard } from '@teambit/legacy.utils';
@@ -51,8 +45,6 @@ import { ExportAspect } from './export.aspect';
 import { ExportCmd } from './export-cmd';
 import { ResumeExportCmd } from './resume-export-cmd';
 
-const HooksManagerInstance = HooksManager.getInstance();
-
 export type OnExportIdTransformer = (id: ComponentID) => ComponentID;
 
 type ModelComponentAndObjects = { component: ModelComponent; objects: BitObject[] };
@@ -100,7 +92,6 @@ export class ExportMain {
   ) {}
 
   async export(params: ExportParams = {}): Promise<ExportResult> {
-    HooksManagerInstance?.triggerHook(PRE_EXPORT_HOOK, params);
     const { nonExistOnBitMap, missingScope, exported, removedIds, exportedLanes, rippleJobs } =
       await this.exportComponents(params);
     let ejectResults: EjectResults | undefined;
@@ -115,7 +106,6 @@ export class ExportMain {
       exportedLanes,
       rippleJobs,
     };
-    HooksManagerInstance?.triggerHook(POST_EXPORT_HOOK, exportResults);
     if (Scope.onPostExport) {
       await Scope.onPostExport(exported, exportedLanes).catch((err) => {
         this.logger.error('fatal: onPostExport encountered an error (this error does not stop the process)', err);

src/constants.ts

@@ -399,69 +399,6 @@ export const POST_MERGE = 'post-merge';
 
 export const GIT_HOOKS_NAMES = [POST_CHECKOUT, POST_MERGE];
 
-/**
- * bit hooks
- */
-export const PRE_TAG_HOOK = 'pre-tag';
-
-export const POST_TAG_HOOK = 'post-tag';
-
-export const POST_ADD_HOOK = 'post-add';
-
-export const PRE_TAG_ALL_HOOK = 'pre-tag-all';
-
-export const POST_TAG_ALL_HOOK = 'post-tag-all';
-
-export const PRE_IMPORT_HOOK = 'pre-import';
-
-export const POST_IMPORT_HOOK = 'post-import';
-
-export const PRE_EXPORT_HOOK = 'pre-export';
-
-export const POST_EXPORT_HOOK = 'post-export';
-
-export const PRE_SEND_OBJECTS = 'pre-send-objects'; // pre-fetch
-
-export const POST_SEND_OBJECTS = 'post-send-objects'; // post-fetch
-
-export const PRE_RECEIVE_OBJECTS = 'pre-receive-objects'; // pre-put
-
-export const POST_RECEIVE_OBJECTS = 'post-receive-objects'; // post-put
-
-export const PRE_DEPRECATE_REMOTE = 'pre-deprecate-remote';
-
-export const PRE_UNDEPRECATE_REMOTE = 'pre-undeprecate-remote';
-
-export const POST_DEPRECATE_REMOTE = 'post-deprecate-remote';
-
-export const POST_UNDEPRECATE_REMOTE = 'post-undeprecate-remote';
-
-export const PRE_REMOVE_REMOTE = 'pre-remove-remote';
-
-export const POST_REMOVE_REMOTE = 'post-remove-remote';
-
-export const HOOKS_NAMES = [
-  PRE_TAG_HOOK,
-  POST_TAG_HOOK,
-  POST_ADD_HOOK,
-  PRE_TAG_ALL_HOOK,
-  POST_TAG_ALL_HOOK,
-  PRE_IMPORT_HOOK,
-  POST_IMPORT_HOOK,
-  PRE_EXPORT_HOOK,
-  POST_EXPORT_HOOK,
-  PRE_SEND_OBJECTS,
-  POST_SEND_OBJECTS,
-  PRE_RECEIVE_OBJECTS,
-  POST_RECEIVE_OBJECTS,
-  PRE_DEPRECATE_REMOTE,
-  PRE_UNDEPRECATE_REMOTE,
-  POST_DEPRECATE_REMOTE,
-  POST_UNDEPRECATE_REMOTE,
-  PRE_REMOVE_REMOTE,
-  POST_REMOVE_REMOTE,
-];
-
 /**
  * bit registry default URL.
  */