fix, skip linking @teambit/legacy, update some deps to remove @teambit/legacy dep (#9459)

Author: davidfirst

e2e/harmony/mocha-tester.e2e.ts

@@ -16,7 +16,7 @@ describe('Mocha Tester', function () {
     before(() => {
       helper.scopeHelper.setNewLocalAndRemoteScopes();
       helper.fixtures.populateComponents(1);
-      helper.command.setEnv('comp1', 'teambit.harmony/envs/core-aspect-env@0.0.42');
+      helper.command.setEnv('comp1', 'teambit.harmony/envs/core-aspect-env');
       helper.command.install();
     });
     describe('component without any test file', () => {
@@ -97,7 +97,7 @@ describe('Mocha Tester', function () {
     before(() => {
       helper.scopeHelper.reInitLocalScope();
       helper.fixtures.populateComponentsTS(1);
-      helper.command.setEnv('comp1', 'teambit.harmony/envs/core-aspect-env@0.0.42');
+      helper.command.setEnv('comp1', 'teambit.harmony/envs/core-aspect-env');
       helper.command.install();
       helper.fs.outputFile(
         'comp1/foo.ts',

scopes/dependencies/dependency-resolver/dependency-linker.ts

@@ -307,7 +307,9 @@ export class DependencyLinker {
     }
 
     if (mainAspectPath) {
-      result.teambitLegacyLink = this.linkNonAspectCorePackages(rootDir, 'legacy', mainAspectPath);
+      // the following line links @teambit/legacy to the workspace node_modules. at this point, we removed all
+      // @teambit/legacy occurrences, so it should be okay to skip this link.
+      // result.teambitLegacyLink = this.linkNonAspectCorePackages(rootDir, 'legacy', mainAspectPath);
       result.harmonyLink = this.linkNonAspectCorePackages(rootDir, 'harmony', mainAspectPath);
     }
     return result;

workspace.jsonc

@@ -126,7 +126,7 @@
         "@teambit/component.ui.component-compare.layouts.compare-split-layout-preset": "^0.0.10",
         "@teambit/component.ui.component-compare.models.component-compare-change-type": "^0.0.7",
         "@teambit/component.ui.component-compare.models.component-compare-hooks": "^0.0.10",
-        "@teambit/component.ui.component-compare.models.component-compare-model": "^0.0.111",
+        "@teambit/component.ui.component-compare.models.component-compare-model": "^0.0.112",
         "@teambit/component.ui.component-compare.models.component-compare-state": "^0.0.7",
         "@teambit/component.ui.component-compare.status-resolver": "^0.0.9",
         "@teambit/component.ui.component-compare.utils.group-by-version": "^0.0.8",
@@ -213,7 +213,7 @@
         "@teambit/evangelist.input.checkbox.label": "^1.1.0",
         "@teambit/evangelist.surfaces.dropdown": "1.0.2",
         "@teambit/explorer.ui.command-bar": "2.0.16",
-        "@teambit/explorer.ui.component-card": "^0.0.30",
+        "@teambit/explorer.ui.component-card": "^0.0.43",
         "@teambit/explorer.ui.gallery.component-grid": "0.0.496",
         "@teambit/git.modules.git-ignore": "^1.0.2",
         "@teambit/graph.cleargraph": "0.0.11",
@@ -223,9 +223,9 @@
         "@teambit/lanes.ui.compare.lane-compare": "^0.0.193",
         "@teambit/lanes.ui.compare.lane-compare-page": "^0.0.162",
         "@teambit/lanes.ui.icons.lane-icon": "^0.0.9",
-        "@teambit/lanes.ui.lane-details": "^0.0.204",
+        "@teambit/lanes.ui.lane-details": "^0.0.205",
         "@teambit/lanes.ui.menus.lanes-overview-menu": "^0.0.10",
-        "@teambit/lanes.ui.models.lanes-model": "^0.0.221",
+        "@teambit/lanes.ui.models.lanes-model": "^0.0.222",
         "@teambit/lanes.ui.navigation.lane-switcher": "^0.0.225",
         "@teambit/legacy-bit-id": "^1.1.1",
         "@teambit/legacy-component-log": "~0.0.402",
@@ -242,15 +242,15 @@
         "@teambit/preview.cli.dev-server-events-listener": "^0.0.1",
         "@teambit/preview.modules.preview-modules": "^1.0.3",
         "@teambit/react.content.react-overview": "1.95.0",
-        "@teambit/react.instructions.react.adding-compositions": "0.0.6",
+        "@teambit/react.instructions.react.adding-compositions": "0.0.7",
         "@teambit/react.instructions.react.adding-tests": "0.0.6",
         "@teambit/react.jest.react-jest": "^1.0.33",
         "@teambit/react.rendering.ssr": "0.0.3",
         "@teambit/react.ui.component-highlighter": "0.2.4",
         "@teambit/react.webpack.react-webpack": "^1.0.37",
         "@teambit/scope.content.scope-overview": "1.95.0",
         "@teambit/scope.ui.empty-scope": "^0.0.509",
-        "@teambit/scope.ui.hooks.use-scope": "^0.0.453",
+        "@teambit/scope.ui.hooks.use-scope": "^0.0.454",
         "@teambit/scope.ui.scope-details": "^0.0.526",
         "@teambit/scope.ui.scope-icon": "0.0.91",
         "@teambit/scopes.scope-descriptor": "^0.0.24",
@@ -733,8 +733,6 @@
             "@teambit/base-react.navigation.link": "2.0.31",
             "@teambit/ui-foundation.ui.navigation.react-router-adapter": "6.1.1",
             "@apollo/client": "3.6.9",
-            // for backward compatibility only
-            "@teambit/legacy": "2.0.1",
             // These are the peer dependencies of Yarn
             "@yarnpkg/cli": "3.6.1",
             "@yarnpkg/core": "3.5.2",