fix(api-for-ide), return the full ripple-job URL when on a lane (#9330)

Author: davidfirst

scopes/harmony/api-server/api-for-ide.ts

@@ -18,7 +18,6 @@ import { getParsedHistoryMetadata } from '@teambit/legacy/dist/consumer/consumer
 import RemovedObjects from '@teambit/legacy/dist/scope/removed-components';
 import { RemoveMain } from '@teambit/remove';
 import { compact, uniq } from 'lodash';
-import { getCloudDomain } from '@teambit/legacy/dist/constants';
 import { ConfigMain } from '@teambit/config';
 import { LANE_REMOTE_DELIMITER, LaneId } from '@teambit/lane-id';
 import { ApplicationMain } from '@teambit/application';
@@ -390,13 +389,13 @@ export class APIForIDE {
   }
 
   async export() {
-    const { componentsIds, removedIds, exportedLanes, rippleJobs } = await this.exporter.export();
-    const rippleJobsFullUrls = rippleJobs.map((job) => `https://${getCloudDomain()}/ripple-ci/job/${job}`);
+    const { componentsIds, removedIds, exportedLanes, rippleJobUrls } = await this.exporter.export();
     return {
       componentsIds: componentsIds.map((c) => c.toString()),
       removedIds: removedIds.map((c) => c.toString()),
       exportedLanes: exportedLanes.map((l) => l.id()),
-      rippleJobs: rippleJobsFullUrls,
+      rippleJobs: rippleJobUrls, // for backward compatibility. bit-extension until 1.1.52 expects rippleJobs.
+      rippleJobUrls,
     };
   }
 

scopes/scope/export/export-cmd.ts

@@ -1,7 +1,7 @@
 import { Command, CommandOptions } from '@teambit/cli';
 import open from 'open';
 import { ejectTemplate } from '@teambit/eject';
-import { WILDCARD_HELP, COMPONENT_PATTERN_HELP, getCloudDomain } from '@teambit/legacy/dist/constants';
+import { WILDCARD_HELP, COMPONENT_PATTERN_HELP } from '@teambit/legacy/dist/constants';
 import chalk from 'chalk';
 import { isEmpty } from 'lodash';
 import { ExportMain, ExportResult } from './export.main.runtime';
@@ -87,7 +87,7 @@ export class ExportCmd implements Command {
       missingScope,
       exportedLanes,
       ejectResults,
-      rippleJobs,
+      rippleJobUrls,
     } = await this.exportMain.export({
       ids,
       eject,
@@ -154,23 +154,16 @@ export class ExportCmd implements Command {
       return `\n${output}`;
     };
     const rippleJobsOutput = () => {
-      if (!rippleJobs.length) return '';
+      if (!rippleJobUrls.length) return '';
       const shouldOpenBrowser = openBrowser && !process.env.CI;
       const prefix = shouldOpenBrowser ? 'Your browser has been opened to the following link' : 'Visit the link below';
       const msg = `\n\n${prefix} to track the progress of building the components in the cloud\n`;
-      const lane = exportedLanes.length ? exportedLanes?.[0] : undefined;
-      const fullUrls = lane
-        ? rippleJobs.map(
-            (job) =>
-              `https://${getCloudDomain()}/${lane.scope.replace('.', '/')}/~lane/${lane.name}/~ripple-ci/job/${job}`
-          )
-        : rippleJobs.map((job) => `https://${getCloudDomain()}/ripple-ci/job/${job}`);
       if (shouldOpenBrowser) {
-        open(fullUrls[0], { url: true }).catch(() => {
+        open(rippleJobUrls[0], { url: true }).catch(() => {
           /** it's ok, the user is instructed to open the browser manually */
         });
       }
-      const urlsColored = fullUrls.map((url) => chalk.bold.underline(url));
+      const urlsColored = rippleJobUrls.map((url) => chalk.bold.underline(url));
       return msg + urlsColored.join('\n');
     };
 

scopes/scope/export/export.main.runtime.ts

@@ -4,7 +4,7 @@ import { ScopeAspect, ScopeMain } from '@teambit/scope';
 import { BitError } from '@teambit/bit-error';
 import { Analytics } from '@teambit/legacy.analytics';
 import { ComponentID, ComponentIdList } from '@teambit/component-id';
-import { CENTRAL_BIT_HUB_NAME, CENTRAL_BIT_HUB_URL } from '@teambit/legacy/dist/constants';
+import { CENTRAL_BIT_HUB_NAME, CENTRAL_BIT_HUB_URL, getCloudDomain } from '@teambit/legacy/dist/constants';
 import { Consumer } from '@teambit/legacy/dist/consumer';
 import { BitMap } from '@teambit/legacy.bit-map';
 import { ComponentsList } from '@teambit/legacy.component-list';
@@ -77,6 +77,7 @@ export interface ExportResult {
   componentsIds: ComponentID[];
   exportedLanes: Lane[];
   rippleJobs: string[];
+  rippleJobUrls: string[];
   ejectResults: EjectResults | undefined;
 }
 
@@ -95,7 +96,7 @@ export class ExportMain {
     let ejectResults: EjectResults | undefined;
     await this.workspace.clearCache(); // needed when one process executes multiple commands, such as in "bit test" or "bit cli"
     if (params.eject) ejectResults = await this.ejectExportedComponents(exported);
-    const exportResults = {
+    const exportResults: ExportResult = {
       componentsIds: exported,
       newIdsOnRemote,
       nonExistOnBitMap,
@@ -104,15 +105,28 @@ export class ExportMain {
       ejectResults,
       exportedLanes,
       rippleJobs,
+      rippleJobUrls: this.getRippleJobUrls(exportedLanes, rippleJobs),
     };
     if (Scope.onPostExport) {
       await Scope.onPostExport(exported, exportedLanes).catch((err) => {
         this.logger.error('fatal: onPostExport encountered an error (this error does not stop the process)', err);
       });
     }
+
     return exportResults;
   }
 
+  private getRippleJobUrls(exportedLanes: Lane[], rippleJobs: string[]): string[] {
+    const lane = exportedLanes.length ? exportedLanes?.[0] : undefined;
+    const rippleJobUrls = lane
+      ? rippleJobs.map(
+          (job) =>
+            `https://${getCloudDomain()}/${lane.scope.replace('.', '/')}/~lane/${lane.name}/~ripple-ci/job/${job}`
+        )
+      : rippleJobs.map((job) => `https://${getCloudDomain()}/ripple-ci/job/${job}`);
+    return rippleJobUrls;
+  }
+
   private async exportComponents({
     ids,
     includeNonStaged,