fix(install) - reload non loaded envs during install before compile (#9130)

Author: GiladShoham

scopes/harmony/aspect-loader/aspect-loader.main.runtime.ts

@@ -766,13 +766,6 @@ export class AspectLoaderMain {
       await this.harmony.load(relevantManifests);
     } catch (e: any) {
       const ids = extensionsManifests.map((manifest) => manifest.id || 'unknown');
-      // TODO: improve texts
-      const errorMsg = e.message.split('\n')[0];
-      const warning = UNABLE_TO_LOAD_EXTENSION_FROM_LIST(ids, errorMsg, neededFor);
-      if (mergedOptions.ignoreErrors) return;
-      if ((e.code === 'MODULE_NOT_FOUND' || e.code === 'ERR_MODULE_NOT_FOUND') && mergedOptions.hideMissingModuleError)
-        return;
-      this.logger.error(warning, e);
       if (mergedOptions.unifyErrorsByExtId) {
         const needToPrint = some(ids, (id) => !this.failedToLoadExt.has(id));
         if (!needToPrint) return;
@@ -786,6 +779,13 @@ export class AspectLoaderMain {
           }
         });
       }
+      if (mergedOptions.ignoreErrors) return;
+      if ((e.code === 'MODULE_NOT_FOUND' || e.code === 'ERR_MODULE_NOT_FOUND') && mergedOptions.hideMissingModuleError)
+        return;
+      // TODO: improve texts
+      const errorMsg = e.message.split('\n')[0];
+      const warning = UNABLE_TO_LOAD_EXTENSION_FROM_LIST(ids, errorMsg, neededFor);
+      this.logger.error(warning, e);
       if (this.logger.isLoaderStarted) {
         if (mergedOptions.throwOnError) throw new BitError(warning);
         this.logger.consoleFailure(warning);

scopes/workspace/install/install.main.runtime.ts

@@ -365,6 +365,7 @@ export class InstallMain {
       let cacheCleared = false;
       await this.linkCodemods(compDirMap);
       await this.reloadMovedEnvs();
+      await this.reloadNonLoadedEnvs();
       const shouldClearCacheOnInstall = this.shouldClearCacheOnInstall();
       if (options?.compile ?? true) {
         const compileStartTime = process.hrtime();
@@ -460,10 +461,18 @@ export class InstallMain {
       return !regularPathExists || !resolvedPathExists;
     });
     const idsToLoad = movedEnvs.map((env) => env.id);
-    // const envPlugin = this.envs.getEnvPlugin();
+    const componentIdsToLoad = idsToLoad.map((id) => ComponentID.fromString(id));
+    await this.reloadEnvs(componentIdsToLoad);
+  }
+
+  private async reloadNonLoadedEnvs() {
+    const nonLoadedEnvs = this.envs.getFailedToLoadEnvs();
+    const componentIdsToLoad = nonLoadedEnvs.map((id) => ComponentID.fromString(id));
+    await this.reloadEnvs(componentIdsToLoad);
+  }
 
-    if (idsToLoad.length && this.workspace) {
-      const componentIdsToLoad = idsToLoad.map((id) => ComponentID.fromString(id));
+  private async reloadEnvs(componentIdsToLoad: ComponentID[]) {
+    if (componentIdsToLoad.length && this.workspace) {
       const aspects = await this.workspace.resolveAspects(undefined, componentIdsToLoad, {
         requestedOnly: true,
         excludeCore: true,
@@ -493,7 +502,6 @@ export class InstallMain {
         })
       );
     }
-    return movedEnvs;
   }
 
   private async _getComponentsManifestsAndRootPolicy(