feat, support publishing to an external registry during snap (#9606)

Author: davidfirst

e2e/harmony/build-cmd.e2e.ts

@@ -52,14 +52,14 @@ describe('build command', function () {
       helper.scopeHelper.setNewLocalAndRemoteScopes();
       helper.fixtures.populateComponents(1);
     });
-    it('should list the publish task in the tagPipeline but not in the snapPipeline', async () => {
+    it('should list the publish task in the tagPipeline and in the snapPipeline', async () => {
       const harmony = await loadBit(helper.scopes.localPath);
       const workspace = harmony.get<Workspace>(WorkspaceAspect.id);
       const compId = await workspace.resolveComponentId('comp1');
       const component = await workspace.get(compId);
       const builder = harmony.get<BuilderMain>(BuilderAspect.id);
       const tasks = builder.listTasks(component);
-      expect(tasks.snapTasks).to.not.include('teambit.pkg/pkg:PublishComponents');
+      expect(tasks.snapTasks).to.include('teambit.pkg/pkg:PublishComponents');
       expect(tasks.tagTasks).to.include('teambit.pkg/pkg:PublishComponents');
     });
   });

e2e/harmony/publish.e2e.4.ts

@@ -60,6 +60,32 @@ describe('publish functionality', function () {
           expect(output.trim()).to.be.equal(appOutput.trim());
         });
       });
+      describe('automatically by snap pipeline', () => {
+        before(() => {
+          helper.scopeHelper.getClonedLocalScope(scopeBeforeTag);
+          helper.command.tagIncludeUnmodified('1.0.5');
+          helper.command.snapAllComponents('--unmodified');
+        });
+        it('should publish them successfully using the 0.0.0-snap version and not changing the "latest" tag', () => {
+          const headSnap = helper.command.getHead('comp1');
+          const comp1Pkg = `@${DEFAULT_OWNER}/${scopeWithoutOwner}.comp1`;
+          const npmTag = helper.command.runCmd(`npm dist-tags ls ${comp1Pkg}`);
+          expect(npmTag).to.have.string('latest: 1.0.5');
+          expect(npmTag).to.have.string(`snap: 0.0.0-${headSnap}`);
+        });
+        it('should publish them successfully and be able to consume them by installing the packages', () => {
+          const headSnap = helper.command.getHead('comp1');
+          helper.scopeHelper.reInitLocalScope();
+          helper.npm.initNpm();
+          helper.npm.installNpmPackage(`@${DEFAULT_OWNER}/${scopeWithoutOwner}.comp1`, `0.0.0-${headSnap}`);
+          helper.fs.outputFile(
+            'app.js',
+            `const comp1 = require('@${DEFAULT_OWNER}/${scopeWithoutOwner}.comp1').default;\nconsole.log(comp1())`
+          );
+          const output = helper.command.runCmd('node app.js');
+          expect(output.trim()).to.be.equal(appOutput.trim());
+        });
+      });
       describe('using "bit publish"', () => {
         before(async () => {
           helper.scopeHelper.getClonedLocalScope(scopeBeforeTag);

scopes/pkg/pkg/pkg.main.runtime.ts

@@ -168,7 +168,7 @@ export class PkgMain {
     // dryRunTask.dependencies = [BuildTaskHelper.serializeId(preparePackagesTask)];
     builder.registerBuildTasks([preparePackagesTask]);
     builder.registerTagTasks([preparePackagesTask, packTask, publishTask]);
-    builder.registerSnapTasks([preparePackagesTask, packTask]);
+    builder.registerSnapTasks([preparePackagesTask, packTask, publishTask]);
 
     const calcPkgOnLoad = async (component: Component) => {
       const data = await pkg.mergePackageJsonProps(component);

scopes/pkg/pkg/publisher.ts

@@ -1,5 +1,6 @@
 import { ComponentResult, TaskMetadata } from '@teambit/builder';
 import { Component, ComponentID } from '@teambit/component';
+import { isSnap } from '@teambit/component-version';
 import { Capsule, IsolatorMain } from '@teambit/isolator';
 import { Logger } from '@teambit/logger';
 import { Workspace } from '@teambit/workspace';
@@ -63,6 +64,7 @@ export class Publisher {
     }
     if (this.options.dryRun) publishParams.push('--dry-run');
     publishParams.push(...this.getTagFlagForPreRelease(capsule.component.id));
+    publishParams.push(...this.getTagFlagForSnap(capsule.component.id));
     const extraArgs = this.getExtraArgsFromConfig(capsule.component);
     if (extraArgs && Array.isArray(extraArgs) && extraArgs?.length) {
       const extraArgsSplit = extraArgs.map((arg) => arg.split(' ')).flat();
@@ -129,6 +131,14 @@ export class Publisher {
     return ['--tag', maybeIdentifier];
   }
 
+  private getTagFlagForSnap(id: ComponentID): string[] {
+    if (isSnap(id.version)) {
+      const snapTag = 'snap';
+      return ['--tag', snapTag];
+    }
+    return [];
+  }
+
   private async getComponentCapsules(componentIds: ComponentID[]): Promise<Capsule[]> {
     const idsToPublish = await this.getIdsToPublish(componentIds);
     this.logger.debug(`total ${idsToPublish.length} to publish out of ${componentIds.length}`);