Skip to content

Introduce padding in the PropList #5010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bieleluk opened this issue May 6, 2025 · 0 comments
Open

Introduce padding in the PropList #5010

bieleluk opened this issue May 6, 2025 · 0 comments
Assignees
Labels
code Code improvements T3W1
Milestone

Comments

@bieleluk
Copy link
Contributor

bieleluk commented May 6, 2025

The current implementation of the PropList does not implement padding between key-value, nor between prop pairs. It is possible to use paragraph function with_spacing to introduce the spacing between each to paragraphs but the result does not look good, specifically in eckhart layout.
The goal is to add this padding directly to the PropList implementation.

On top of that, the ConfirmValueParams strongly resembles the PropList with 3 properties so we should find out if it's feasible to fuse them into one struct.

@bieleluk bieleluk added this to the UI Eckhart milestone May 6, 2025
@bieleluk bieleluk self-assigned this May 6, 2025
@bieleluk bieleluk added code Code improvements T3W1 labels May 6, 2025
@bieleluk bieleluk added this to Firmware May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements T3W1
Projects
Status: No status
Development

No branches or pull requests

1 participant