Skip to content

Solana: improving titles & instructions #5062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibz opened this issue May 19, 2025 · 1 comment
Open

Solana: improving titles & instructions #5062

ibz opened this issue May 19, 2025 · 1 comment
Labels
code Code improvements

Comments

@ibz
Copy link
Contributor

ibz commented May 19, 2025

Quoting @matejcik from here:

"Assign with Seed" should be the title of the screen, "System Program" is the subtitle
we can hide "1/1" in all cases. i think it's generally ok to also hide any "m/n" -- given the screen labels, I don't think how much value it brings to the user to see the instruction counter. what do you think @lapohoda @Hannsek ?

Image

(speaking of, someone should go through Solana programs and improve the labels. they are "names of instructions" but what we want is "user-visible name of operation", which, e.g. in "Transfer Checked" is just "Transfer")

@ibz ibz added the code Code improvements label May 19, 2025
@trezor-bot trezor-bot bot added this to Firmware May 19, 2025
@Hannsek
Copy link
Contributor

Hannsek commented May 19, 2025

I think we can get rid of the instruction counters.
Let's do it as you said:

Assign With Seed
System Program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements
Projects
Status: No status
Development

No branches or pull requests

2 participants