Skip to content

coveragedata is included in production #5092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matejcik opened this issue May 25, 2025 · 0 comments · Fixed by #5093
Closed

coveragedata is included in production #5092

matejcik opened this issue May 25, 2025 · 0 comments · Fixed by #5093
Assignees
@romanz
Labels
code Code improvements

Comments

@matejcik
Copy link
Contributor

two problems with coveragedata module:

  • it's not conditionally disabled for prod builds,
  • it lives in micropython where it arguably doesn't belong, being (a) an exported module (other parts of micropython are for Rust whereas this one is for Python, (b) kiiiind of a general key-value store
@matejcik matejcik added the code Code improvements label May 25, 2025
@trezor-bot trezor-bot bot added this to Firmware May 25, 2025
@romanz romanz linked a pull request May 26, 2025 that will close this issue
chore(core): move coverage-related Rust code into a separate module #5093
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romanz romanz

Labels
code Code improvements
Projects
Firmware
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(core): move coverage-related Rust code into a separate module trezor/trezor-firmware
2 participants
@romanz @matejcik