Skip to content

Refactor deploy package error handling #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
infomiho opened this issue May 21, 2025 · 1 comment
Open

Refactor deploy package error handling #2782

infomiho opened this issue May 21, 2025 · 1 comment
Labels
deployment refactoring Keeping that code clean!

Comments

@infomiho
Copy link
Contributor

Based on #2578 (comment)

We should avoid calling exit in the helper functions and throw instead. We should handle the throws at the top level and then exit with code 1.
@infomiho infomiho added refactoring Keeping that code clean! deployment labels May 21, 2025
@infomiho infomiho mentioned this issue May 21, 2025
Open
3 tasks
@sodic
Copy link
Contributor

sodic commented May 22, 2025

Should we adopt it everywhere then (for example, here)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deployment refactoring Keeping that code clean!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@infomiho @sodic