Skip to content

Commit bad7043

Browse files
authored
chore: govern webpack test cases (#10337)
* chore: govern webpack test cases * chore: govern webpack test cases * chore: govern webpack test cases * chore: govern webpack test cases * chore: govern webpack test cases * chore: govern webpack test cases * chore: govern webpack test cases
1 parent 235b3e7 commit bad7043

File tree

142 files changed

+283
-303
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

142 files changed

+283
-303
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = () => { return 'https://github.com/web-infra-dev/rspack/issues/8490' }
1+
module.exports = () => { return 'TODO: https://github.com/web-infra-dev/rspack/issues/8490' }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = () => { return 'https://github.com/web-infra-dev/rspack/issues/8531' }
1+
module.exports = () => { return 'TODO: https://github.com/web-infra-dev/rspack/issues/8531' }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = () => { return 'https://github.com/web-infra-dev/rspack/issues/8488' }
1+
module.exports = () => { return 'TODO: https://github.com/web-infra-dev/rspack/issues/8488' }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: parser walk IIFE not supported" }

tests/webpack-test/configCases/async-module/environment-not-support-async-warning/test.filter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
// };
55

66
// Expecting warnings `The generated code contains 'async\/await'`
7-
module.exports = () => false;
7+
module.exports = () => "FIXME: warnings are missing";
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
module.exports = () => {
2-
// we don't have plan to support module.unsafeCache and snapshot.managedPaths
3-
return -1;
2+
return "NOPLAN: support module.unsafeCache and snapshot.managedPaths";
43
};
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
module.exports = () => {
2-
// we don't have plan to support module.unsafeCache and snapshot.managedPaths
3-
return -1;
2+
return "NOPLAN: support module.unsafeCache and snapshot.managedPaths";
43
};
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
// enable when support compilation.moduleGraph(unimplemented).getPreOrderIndex(unimplemented)
22
module.exports = () => {
3-
return 'https://github.com/web-infra-dev/rspack/issues/8548';
3+
return 'TODO: https://github.com/web-infra-dev/rspack/issues/8548';
44
};
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = () => { return 'https://github.com/web-infra-dev/rspack/issues/8549' }
1+
module.exports = () => { return 'TODO: https://github.com/web-infra-dev/rspack/issues/8549' }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = () => { return 'https://github.com/web-infra-dev/rspack/issues/8603' }
1+
module.exports = () => { return 'TODO: https://github.com/web-infra-dev/rspack/issues/8603' }

tests/webpack-test/configCases/clean/link/test.filter.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,4 @@
1616
// }
1717
// };
1818

19-
// TODO: Should create a issue for this test
20-
module.exports = () => { return false }
19+
module.exports = () => { return "FIXME: link is not supported when clean" }
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
// `optimization.moduleIds = "hashed"` is deprecated in webpack.
2-
// So we do not have to implement in Rspack.
3-
module.exports = () => { return -1 }
1+
module.exports = () => { return "NOPLAN: optimization.moduleIds = 'hashed' is deprecated in webpack" }
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
// rspack don't have ContextExclusionPlugin.
2-
// skip it, because ContextExclusionPlugin already instead of IgnorePlugin.
3-
module.exports = () => { return -1 }
1+
module.exports = () => { return "NOPLAN: ContextExclusionPlugin already instead of IgnorePlugin" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "FIXME: Cannot find module 'replaced'" }
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
// do not support webpack.ids.DeterministicModuleIdsPlugin
2-
// TODO: Should create a issue for this test
32
module.exports = () => false;
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
// do not support webpack.ids.DeterministicModuleIdsPlugin
2-
// TODO: Should create a issue for this test
32
module.exports = () => false;

tests/webpack-test/configCases/css/universal/test.filter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
// };
55

66
// For the selected environment is no default ESM chunk format available
7-
module.exports = () => false;
7+
module.exports = () => "FIXME: panic ' invalid wasm loading type: universal'";
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
21
module.exports = () => false;
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// custom function type hash function will hurt performance
2-
module.exports = () => {return -1}
1+
module.exports = () => "NOPLAN: custom function type hash function will hurt performance";
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "NOPLAN: normalModuleFactory.hooks not supported" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "NOPLAN: compilation.hooks.dependencyReferencedExports not supported" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "NOPLAN: compilation.hooks.dependencyReferencedExports not supported" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: DelegatedPlugin is not exposed" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: DelegatedPlugin is not exposed" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: chunk API not be full supported" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: chunk files API not be full supported" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "FIXME: missing deprecation DEP_WEBPACK_CONFIGURATION_OPTIMIZATION_NO_EMIT_ON_ERRORS" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: module.addCacheDependencies not supported" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "TODO: compilation.hooks.afterModuleHash not supported" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = () => { return false }
1+
module.exports = () => { return "NOPLAN: moduleIds: hashed has been deprecated" }

tests/webpack-test/configCases/dll-plugin/3-use-dll-with-hashid/webpack.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ module.exports = {
1919
]
2020
},
2121
optimization: {
22-
// TODO: moduleIds: "hashed" is not implements
2322
moduleIds: "hashed"
2423
},
2524
plugins: [
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = () => { return "afterSeal hook blocks" }
1+
module.exports = () => { return "TODO: compilation.hooks.afterSeal not supported" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "FIXME: entry path parsed failed" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "FIXME: entry path parsed failed" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "FIXME: missing error" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "FIXME: missing error" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: compilation.mainTemplate.hooks.requireExtensions not supported" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: DeterministicModuleIdsPlugin is not exposed" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "NOPLAN: HashedModuleIdsPlugin has been deprecated" }

tests/webpack-test/configCases/hash-length/output-filename/test.filter.js

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/webpack-test/configCases/hash-length/output-filename/webpack.config.js

Lines changed: 33 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
var webpack = require("@rspack/core");
2+
// CHANGE: rspack use 16 length xxhash by default
23
/** @type {import("@rspack/core").Configuration[]} */
34
module.exports = [
45
{
@@ -21,8 +22,10 @@ module.exports = [
2122
chunkFilename: "[id].bundle1.[fullhash].js"
2223
},
2324
amd: {
24-
expectedFilenameLength: 31,
25-
expectedChunkFilenameLength: 33
25+
// expectedFilenameLength: 31,
26+
// expectedChunkFilenameLength: 33
27+
expectedFilenameLength: 27,
28+
expectedChunkFilenameLength: 29
2629
}
2730
},
2831
{
@@ -43,8 +46,10 @@ module.exports = [
4346
chunkFilename: "[id].bundle3.[chunkhash].js"
4447
},
4548
amd: {
46-
expectedFilenameLength: 31,
47-
expectedChunkFilenameLength: 33
49+
// expectedFilenameLength: 31,
50+
// expectedChunkFilenameLength: 33
51+
expectedFilenameLength: 27,
52+
expectedChunkFilenameLength: 29
4853
}
4954
},
5055
{
@@ -54,7 +59,8 @@ module.exports = [
5459
chunkFilename: "[id].bundle4.[fullhash:8].js"
5560
},
5661
amd: {
57-
expectedFilenameLength: 31,
62+
// expectedFilenameLength: 31,
63+
expectedFilenameLength: 27,
5864
expectedChunkFilenameLength: 21
5965
}
6066
},
@@ -76,7 +82,8 @@ module.exports = [
7682
chunkFilename: "[id].bundle6.[chunkhash:7].js"
7783
},
7884
amd: {
79-
expectedFilenameLength: 31,
85+
// expectedFilenameLength: 31,
86+
expectedFilenameLength: 27,
8087
expectedChunkFilenameLength: 20
8188
},
8289
plugins: [new webpack.HotModuleReplacementPlugin()]
@@ -101,7 +108,8 @@ module.exports = [
101108
},
102109
target: "node",
103110
amd: {
104-
expectedFilenameLength: 31,
111+
// expectedFilenameLength: 31,
112+
expectedFilenameLength: 27,
105113
expectedChunkFilenameLength: 20
106114
}
107115
},
@@ -113,7 +121,8 @@ module.exports = [
113121
},
114122
target: "node",
115123
amd: {
116-
expectedFilenameLength: 31,
124+
// expectedFilenameLength: 31,
125+
expectedFilenameLength: 27,
117126
expectedChunkFilenameLength: 20
118127
}
119128
},
@@ -125,8 +134,10 @@ module.exports = [
125134
},
126135
target: "node",
127136
amd: {
128-
expectedFilenameLength: 32,
129-
expectedChunkFilenameLength: 34
137+
// expectedFilenameLength: 32,
138+
//
139+
expectedFilenameLength: 28,
140+
expectedChunkFilenameLength: 30
130141
}
131142
},
132143
{
@@ -149,8 +160,10 @@ module.exports = [
149160
},
150161
target: "async-node",
151162
amd: {
152-
expectedFilenameLength: 32,
153-
expectedChunkFilenameLength: 34
163+
// expectedFilenameLength: 32,
164+
// expectedChunkFilenameLength: 34
165+
expectedFilenameLength: 28,
166+
expectedChunkFilenameLength: 30
154167
}
155168
},
156169
{
@@ -175,8 +188,10 @@ module.exports = [
175188
},
176189
target: "web",
177190
amd: {
178-
expectedFilenameLength: 32,
179-
expectedChunkFilenameLength: 34
191+
// expectedFilenameLength: 32,
192+
// expectedChunkFilenameLength: 34
193+
expectedFilenameLength: 28,
194+
expectedChunkFilenameLength: 30
180195
}
181196
},
182197
{
@@ -203,8 +218,10 @@ module.exports = [
203218
},
204219
target: "webworker",
205220
amd: {
206-
expectedFilenameLength: 32,
207-
expectedChunkFilenameLength: 34
221+
// expectedFilenameLength: 32,
222+
// expectedChunkFilenameLength: 34
223+
expectedFilenameLength: 28,
224+
expectedChunkFilenameLength: 30
208225
}
209226
},
210227
{
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "FIXME: used exports is not as expected" }

tests/webpack-test/configCases/inner-graph/class/test.filter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
// };
66

77
// TODO: Should create a issue for this test
8-
module.exports = () => { return false }
8+
module.exports = () => { return "FIXME: deepEqual is used" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "FIXME: im1 is used" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "FIXME: exports is not as expected" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "FIXME: im1 is used" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "FIXME: im1 is used" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "NOPLAN: Ignore the json named exports warning, this violates standards, but other bundlers support it without warning." }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "FIXME: externals is not invalid type" }
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// var supportsOptionalChaining = require("../../../helpers/supportsOptionalChaining");
22
// module.exports = function (config) {
3-
// return supportsOptionalChaining();
3+
// return supportsOptionalChaining();
44
// };
55

6-
// panic: should have mgm
7-
module.exports = () => false;
6+
module.exports = () => { return "FIXME: build timeout on CI" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "FIXME: missing error" }

tests/webpack-test/configCases/loaders/pr-14384/test.filter.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/webpack-test/configCases/managedPaths/futureDefaults/test.filter.js

Lines changed: 0 additions & 2 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "FIXME: mangle result not as expected" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "TODO: DeterministicChunkIdsPlugin is not exposed" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
2+
module.exports = () => { return "NOPLAN: moduleIds: 'hashed' has been deprecated" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: not support module.unknownContextRegExp/unknownContextCritical/exprContextRegExp" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: not support module.strictThisContextOnImports" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "TODO: not support module.unknownContextRegExp/unknownContextCritical/exprContextRegExp" }
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
// TODO: Should create a issue for this test
2-
module.exports = () => { return false }
1+
module.exports = () => { return "NOPLAN: support parser.system to parse systemjs" }

0 commit comments

Comments
 (0)