Skip to content

Commit a78f96a

Browse files
authored
fix: make element prop optional for BulkAction (#3687)
1 parent 20e651b commit a78f96a

File tree

3 files changed

+12
-6
lines changed
  • packages
    • app-file-manager/src/modules/FileManagerRenderer/FileManagerView/configComponents/Browser
    • app-headless-cms/src/admin/config/contentEntries/list/Browser
    • app-page-builder/src/admin/config/pages/list/Browser

3 files changed

+12
-6
lines changed

packages/app-file-manager/src/modules/FileManagerRenderer/FileManagerView/configComponents/Browser/BulkAction.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export interface BulkActionProps {
1414
remove?: boolean;
1515
before?: string;
1616
after?: string;
17-
element: React.ReactElement;
17+
element?: React.ReactElement;
1818
}
1919

2020
export const BaseBulkAction: React.FC<BulkActionProps> = ({
@@ -40,7 +40,9 @@ export const BaseBulkAction: React.FC<BulkActionProps> = ({
4040
after={placeAfter}
4141
>
4242
<Property id={getId(name, "name")} name={"name"} value={name} />
43-
<Property id={getId(name, "element")} name={"element"} value={element} />
43+
{element ? (
44+
<Property id={getId(name, "element")} name={"element"} value={element} />
45+
) : null}
4446
</Property>
4547
</Property>
4648
);

packages/app-headless-cms/src/admin/config/contentEntries/list/Browser/BulkAction.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export interface BulkActionProps {
1515
before?: string;
1616
after?: string;
1717
modelIds?: string[];
18-
element: React.ReactElement;
18+
element?: React.ReactElement;
1919
}
2020

2121
export const BaseBulkAction: React.FC<BulkActionProps> = ({
@@ -47,7 +47,9 @@ export const BaseBulkAction: React.FC<BulkActionProps> = ({
4747
after={placeAfter}
4848
>
4949
<Property id={getId(name, "name")} name={"name"} value={name} />
50-
<Property id={getId(name, "element")} name={"element"} value={element} />
50+
{element ? (
51+
<Property id={getId(name, "element")} name={"element"} value={element} />
52+
) : null}
5153
</Property>
5254
</Property>
5355
);

packages/app-page-builder/src/admin/config/pages/list/Browser/BulkAction.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export interface BulkActionProps {
1414
remove?: boolean;
1515
before?: string;
1616
after?: string;
17-
element: React.ReactElement;
17+
element?: React.ReactElement;
1818
}
1919

2020
export const BaseBulkAction: React.FC<BulkActionProps> = ({
@@ -40,7 +40,9 @@ export const BaseBulkAction: React.FC<BulkActionProps> = ({
4040
after={placeAfter}
4141
>
4242
<Property id={getId(name, "name")} name={"name"} value={name} />
43-
<Property id={getId(name, "element")} name={"element"} value={element} />
43+
{element ? (
44+
<Property id={getId(name, "element")} name={"element"} value={element} />
45+
) : null}
4446
</Property>
4547
</Property>
4648
);

0 commit comments

Comments
 (0)