fix: use name instead of type #4506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
changed the title
configureAdminCognitoFederation - Use Name Instead of Type Where Needed
Pavel910
approved these changes
Jan 31, 2025
adrians5j
changed the title
configureAdminCognitoFederation - Use Name Instead of Type Where Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, we're addressing an issue where, upon using the
configureAdminCognitoFederationand thenameprop with the OIDC provider, the deployment would fail with with the following error message:InvalidParameterException: The provider OIDC does not exist for User Pool eu-central-1_k5dRgsz9WThis was happening because, in case
nameis provided, internally, instead of using it when linking with the user pool client, the providertypewould be used.In other words, if we take a look at the example below, the identity provider
auth0would get created, but when it comes to linking it with the user pool client, theOIDCvalue would be used, instead ofauth0. And, of course, since theOIDCprovider does not exist, Pulumi throws the above error.So, with this PR, we're addressing this issue, by ensuring the name is actually used when linking with the UPC, instead of the type.
How Has This Been Tested?
Manually.
Documentation
Changelog.