This repository was archived by the owner on Jul 9, 2021. It is now read-only.
Reenable CircleCi tests for swapper + orderbook, and fix migrations bug #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dekz
force-pushed
the
fix/reenable-builds-for-v3
branch
from
60ec141 to
1576753
Compare
added 2 commits
November 25, 2019 14:40
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slight fix to migrations package to receive a
providerinstead of instantiate one on its own.Reenabled tests in circleci as well.
Updates
@0x/migrationsto deploy Forwarder after Exchange is configured. This results in new contract-addresses on1337. Contract-addresses have been updated to reflect this.Testing instructions
Types of changes
Checklist: