-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(thunderx,pikpak): add offline download support for ThunderX; add ctx to specific PikPak functions #8491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… ctx to specific PikPak functions
WalkthroughThis PR introduces offline download support for ThunderX and adds context (ctx) to specific PikPak functions. It involves significant changes to the ThunderX driver, including new functions for handling offline downloads, task management, and integration with existing systems. Changes
|
} | ||
filtersJSON, err := json.Marshal(filters) | ||
if err != nil { | ||
return nil, fmt.Errorf("failed to marshal filters: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error handling here should ensure that filtersJSON
is properly marshaled before being used in the params
map. If the marshaling fails, it could lead to unexpected behavior or security vulnerabilities if the error isn't handled correctly.
要不还是参考下我的实现思路吧:https://github.com/ykxVK8yL5L/alist |
基于ThunderX的功能写完了啊(还缺什么吗 |
我的意思是换下思路 把离线功能的扩展交给driver去处理 这样如果需要扩展只需要driver去实现offline的接口即可 |
我是跟随官方架构改的这样,不想大动主线
|
好的 我之前给官方提交过 感觉官方响应太慢 所以就自己搞了 能满足需要就好😊 |
frontend AlistGo/alist-web#280