-
-
Notifications
You must be signed in to change notification settings - Fork 376
feat: add joined at and avatar url for member list endpoint #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add joined at and avatar url for member list endpoint #1355
Conversation
Reviewer's Guide by SourceryThis pull request enhances the member list and get member endpoints by adding 'joined at' and 'avatar url' fields. The changes involve updating SQL queries, data structures, and API response handling to include these new fields. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @khorshuheng - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a database migration to populate the
icon_url
metadata field for existing users. - It looks like the
avatar_url
field is being read from themetadata
column, is there a reason it's not a dedicated column?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Add joined at and avatar url for member list and get member endpoint
Summary by Sourcery
Enhance workspace member endpoints by adding avatar URL and joined timestamp
New Features:
Enhancements: