-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Viewer: Add shadow support #16459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewer: Add shadow support #16459
Conversation
Various fixes
Spotlight shadow
Reviewer - this PR has made changes to one or more package.json files. |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Reviewer - this PR has made changes to one or more package.json files. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16459/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16459/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16459/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
…classic shadows into a broken state Ignore AbortErrors and log other errors for async work done in sync functions Make all root meshes shadow casters Don't expose high quality (IBL) shadows yet, since there are some outstanding issues to resolve
Some classic shadow tuning
Reviewer - this PR has made changes to one or more package.json files. |
Reviewer - this PR has made changes to one or more package.json files. |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
In the viewer, add the support for :
normal
,high
For now, ibl shadows are dissabled for meshes that have animations in WebGPU even if the animation is paused as there is some issues.
The auto shadow selection will come in another PR.
The placement of the light will come in another PR.
Edit from @ryantrem: from local testing, these are the remaining issues I'm seeing:
<babylon-viewer shadow-quality="normal">
).