Skip to content

USDZ Exporter: Some small fixes #16594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025

Conversation

alexchuber
Copy link
Contributor

@alexchuber alexchuber commented May 12, 2025

  • Retrieve Normal vertex buffer
  • Retrieve correct UV set indices
  • Add clearcoat support for PBR materials
  • Allow export with an odd number of negative scales (aka flipped orientation). Not sure if it is the ideal fix, but my rationale is
    • This is what Three does, and seems to work OK.
    • This piece of documentation (last paragraph of https://openusd.org/release/api/usd_geom_page_front.html#UsdGeom_WindingOrder) seems to suggest that handling the orientation flip can be a run/load-time operation? Or, at least, I can't find anyplace where it says that this must be done at export-time. Someone please correct me if I'm wrong :)

@alexchuber alexchuber requested a review from deltakosh May 12, 2025 21:14
@bjsplat
Copy link
Collaborator

bjsplat commented May 12, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 12, 2025

@deltakosh deltakosh merged commit 7fd617b into BabylonJS:master May 12, 2025
17 checks passed
RolandCsibrei pushed a commit to RolandCsibrei/Babylon.js that referenced this pull request May 15, 2025
- Retrieve Normal vertex buffer
- Retrieve correct UV set indices
- Add clearcoat support for PBR materials
- Allow export with an odd number of negative scales (aka flipped
orientation). Not the ideal fix, but my rationale is
   - This is what Three does, and seems to work OK.
- This piece of documentation (last paragraph of
https://openusd.org/release/api/usd_geom_page_front.html#UsdGeom_WindingOrder)
seems to suggest that handling the orientation flip can be a
run/load-time operation? Or, at least, I can't find anyplace where it
says that this must be done at export-time. Someone please correct me if
I'm wrong :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants