-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat: integration/conn v1->v2 #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Devanshusisodiya
wants to merge
23
commits into
master
Choose a base branch
from
feat/v1-v2-shift
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
54eb407
feat: integration/conn v1->v2
Devanshusisodiya 8bbfe42
fix: cleanup code
Devanshusisodiya 64ea12d
fix: raise warning if force_integration param is passed
Devanshusisodiya 2e7f54e
Merge with master
Devanshusisodiya b61ddb2
chore: fmt chk
Devanshusisodiya bae6dc0
Merge branch 'master' into feat/v1-v2-shift
Devanshusisodiya a0d6dce
docs: added comments
Devanshusisodiya 4a9b332
test: fix example test
Devanshusisodiya 8c38f15
test: added e2e test
Devanshusisodiya 28231c9
fix: test classname
Devanshusisodiya cb4efdb
updated e2e test
Devanshusisodiya 9f22d5d
fix: tests not running in ci
Devanshusisodiya 0e28ebe
Merge branch 'master' into feat/v1-v2-shift
Devanshusisodiya ff67ce1
chore: fmt chk
Devanshusisodiya aeebe12
Revert "chore: fmt chk"
Devanshusisodiya b149777
chore: fmt chk
Devanshusisodiya 1741af8
fix: review comments
Devanshusisodiya c8137b6
Merge branch 'master' into feat/v1-v2-shift
Devanshusisodiya 85ceabe
Merge branch 'master' into feat/v1-v2-shift
Devanshusisodiya 79ac8b8
fix: fail with pytest
Devanshusisodiya ace9c6d
Revert "fix: fail with pytest"
Devanshusisodiya 594dc06
fix: fail with pytets
Devanshusisodiya e57e43e
fix: initiate_connection on toolset
Devanshusisodiya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1260,17 +1260,16 @@ def create_integration( | |
auth_mode: t.Optional[AuthSchemeType] = None, | ||
auth_config: t.Optional[t.Dict[str, t.Any]] = None, | ||
use_composio_oauth_app: bool = True, | ||
force_new_integration: bool = False, | ||
force_new_integration: bool = False, # pylint: disable=unused-argument | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deprecation warning There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added. |
||
) -> IntegrationModel: | ||
app_data = self.client.apps.get(name=str(app)) | ||
timestamp = datetime.now().strftime("%Y%m%d%H%M%S") | ||
return self.client.integrations.create( | ||
app_id=app_data.appId, | ||
app_unique_key=app_data.name, | ||
name=f"{app}_{timestamp}", | ||
auth_mode=auth_mode, | ||
auth_config=auth_config, | ||
use_composio_auth=use_composio_oauth_app, | ||
force_new_integration=force_new_integration, | ||
) | ||
|
||
def initiate_connection( | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.