Skip to content

perf: G1/2 membership using Eval #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

yelhousni
Copy link
Contributor

@yelhousni yelhousni commented Dec 16, 2024

Description

Forgot to push this in #1349.
G1 and G2 subgroup membership using Eval for curve and twist arithmetics.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

TestGroupMembershipSolve passes.

How has this been benchmarked?

This saves 101,565 scs for GroupMembershipCircuit.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni added consolidate strengthen an existing feature perf labels Dec 16, 2024
@yelhousni yelhousni added this to the v0.11.N milestone Dec 16, 2024
@yelhousni yelhousni requested a review from ivokub December 16, 2024 18:25
@yelhousni yelhousni self-assigned this Dec 16, 2024
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I see how you have inlined the Ext2 ops. But have a look at the comment for G1.doubleAndAdd, I don't follow the change of sign.

@yelhousni yelhousni merged commit 0a3bf3c into master Dec 16, 2024
5 checks passed
@yelhousni yelhousni deleted the perf/bls12381-group-membership branch December 16, 2024 23:32
lucasmenendez pushed a commit to lucasmenendez/gnark that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants