Skip to content

chore: various major dependency updates #10501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dtomvan
Copy link

@dtomvan dtomvan commented May 21, 2025

Fixes #10500

Maybe monkeypatching in the upstream unix/pty.cc wasn't a good idea; the output app hangs after loading screen... No idea why, don't know how to debug that.

But I think this is a good foundation to start with nontheless... just trying to help out here :)

@dtomvan
Copy link
Author

dtomvan commented May 21, 2025

I just moved the actions to corepack... at least this way act can get to actually running yarn, which it couldn't before anymore because yarn v1 is of course incompatible with yarn v4.

Edit: yeah that glasstron failure happened to me on act but not locally. I think GH actions has a missing dep.

@Eugeny
Copy link
Owner

Eugeny commented May 24, 2025

Sorry but this PR makes no sense to me as it is right now. You've downgraded node-pty to 0.12 (?!), replacing it with a binary build but then throw in a bunch of source patches for it (?) that won't be used because it's already prebuilt.

@dtomvan
Copy link
Author

dtomvan commented May 24, 2025

Yeah that was a bit hacky. It seems like the only way to get it working on nixos (while keeping it functional for other distros as its prebuilt for those). I think I could try to use the trunk version of MS instead. I don't think I have time for that right this week though I'm sorry.

@dtomvan dtomvan force-pushed the dtomvan/push-psrqnnpvrlvn branch from 001ec0c to 82933b4 Compare May 24, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron 32 is EOL
2 participants