-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
chore: various major dependency updates #10501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I just moved the actions to corepack... at least this way Edit: yeah that |
Sorry but this PR makes no sense to me as it is right now. You've downgraded node-pty to 0.12 (?!), replacing it with a binary build but then throw in a bunch of source patches for it (?) that won't be used because it's already prebuilt. |
Yeah that was a bit hacky. It seems like the only way to get it working on nixos (while keeping it functional for other distros as its prebuilt for those). I think I could try to use the trunk version of MS instead. I don't think I have time for that right this week though I'm sorry. |
This is the official way to install yarn v4
001ec0c
to
82933b4
Compare
Fixes #10500
Maybe monkeypatching in the upstream
unix/pty.cc
wasn't a good idea; the output app hangs after loading screen... No idea why, don't know how to debug that.But I think this is a good foundation to start with nontheless... just trying to help out here :)