Remove FR_LOCATE_DIR macro

[floppym]

Calling "locate" to find include and library paths makes no sense. The
locate database may contain paths comprised of files meant for entirely
different toolchains.

Fixes: #4317

[thesamesam]

Note that locate may also find files which do not exist on the system (removed since the last DB update, usually done daily or weekly) or fail to find new files. It's really intended for users to find files rather than within build systems or automated processes which expect to find them in standard-ish locations.

We already have pkg-config which is being used + some additional logic in the build system within FreeRADIUS to go looking for libs and headers, so locate should not be needed at all. Again, this is the first time I've ever seen it used in a build system.

[stintel]

Tested-by: Stijn Tintel <[email protected]>

[alandekok]

Fix has been pushed.

[floppym]

@alandekok The code still exists in the master branch. Is there some reason for that?

[alandekok]

@floppym We haven't gotten to it yet.

Plus, the "master" branch has not been released as v4, and is not yet supported.

[floppym]

Thanks, just wanted to make sure it wasn't missed by mistake.