don't build rocksdb in fuel-core #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezna
force-pushed
the
sezna/pipeline-speed
branch
from
bf315f8 to
0b23034
Compare
|
You might have better luck spinning up the server in-process with your tests rather than trying to run it as an external process. Take a look at the fuel-client integ tests for an example: As an added bonus you'll be able to set breakpoints in the vm or fuel-core if you need to debug your tests. edit: I realized the default feature flag was disabling too many things unrelated to rocksdb, so I opened a PR here to improve this. Let me know if this works better for you: FuelLabs/fuel-core#55 |
|
With that PR merged in to fuel-core, do you think this approach would work for now until we switch to in-process? |
otrho
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the
build fuel-corepipeline step by around 7 minutes.