Fixes argument errors not displayed. #5909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
added
compiler: frontend
Benchmark for 60e752fClick to view benchmark
|
type_check_method_application does the parsing of arguments in 2 passes, but when the resolved_method_name failed the argument error would not be displayed. We now store the arg_handlers and append their errors in case resolve_method_name fails. Fixes #5660
esdrubal
force-pushed
the
esdrubal/5660_fix_arg_error_not_displayed
branch
from
5d6ae37 to
e9c18b5
Compare
esdrubal
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
CodSpeed Performance ReportMerging #5909 will not alter performanceComparing Summary
|
jjcnn
approved these changes
Feb 4, 2025
tritao
approved these changes
Feb 4, 2025
JoshuaBatty
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
sdankel
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Description `type_check_method_application` does the parsing of arguments in 2 passes, but when the `resolved_method_name` failed the argument error would not be displayed. We now store the arg_handlers and append their errors in case `resolve_method_name` fails. Fixes #5660 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers. Co-authored-by: Joshua Batty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
type_check_method_applicationdoes the parsing of arguments in 2 passes, but when theresolved_method_namefailed the argument error would not be displayed.We now store the arg_handlers and append their errors in case
resolve_method_namefails.Fixes #5660
Checklist
Breaking*orNew Featurelabels where relevant.