-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add bldd
case to Op::parse_opcode()
#6957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #6957 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the ecal tests need to be updated; I'm assuming I probably did them incorrectly on the first pass; thanks for fixing.
LGTM 👍
@zees-dev No worries 😄 And thanks for asking for tests to be written! To your question, we have guidelines for writing E2E tests but no lints that would warn developers when not following them. Essentially, if a test could be a |
Description
The
bldd
opcode was not covered in theOp::parse_opcode()
which resulted inUnknown opcode: "bldd"
error.The remaining part of the
bldd
opcode integration chain is already implemented in #6254.Checklist
Breaking*
orNew Feature
labels where relevant.