-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Fix relative path resolution with temp manifests in LSP #7079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3d68215
to
f29d71d
Compare
CodSpeed Performance ReportMerging #7079 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
e4cbc13
to
6bed197
Compare
6bed197
to
6cc396c
Compare
… for dependencies and removed unnecessary comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
b603793
to
35cd155
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
The LSP now properly detects changes to
Forc.toml
files and updates build plans immediately, allowing for dynamic dependency modifications without requiring a server restart.Previously, LSP was using old cached versions of the manifest files so new deps added were only being picked up and compiled after restarting the IDE.
Note, the change is only applied after the next did change event occurs, thus triggering a recompilation. A follow up PR to this will use the
did_change_watched_files
event to trigger recompilation automatically. I've opened an issue for that here #7103Checklist
Breaking*
orNew Feature
labels where relevant.