Skip to content

Fix relative path resolution with temp manifests in LSP #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 24, 2025

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Apr 11, 2025

Description

The LSP now properly detects changes to Forc.toml files and updates build plans immediately, allowing for dynamic dependency modifications without requiring a server restart.

Previously, LSP was using old cached versions of the manifest files so new deps added were only being picked up and compiled after restarting the IDE.

Note, the change is only applied after the next did change event occurs, thus triggering a recompilation. A follow up PR to this will use the did_change_watched_files event to trigger recompilation automatically. I've opened an issue for that here #7103

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested a review from a team as a code owner April 11, 2025 04:17
@JoshuaBatty JoshuaBatty marked this pull request as draft April 11, 2025 04:18
@JoshuaBatty JoshuaBatty self-assigned this Apr 11, 2025
@JoshuaBatty JoshuaBatty added bug Something isn't working language server LSP server labels Apr 11, 2025
@JoshuaBatty JoshuaBatty force-pushed the josh/lsp_workspace_bug branch from 3d68215 to f29d71d Compare April 11, 2025 04:39
Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Performance Report

Merging #7079 will not alter performance

Comparing josh/lsp_workspace_bug (9eeb4d2) with master (760a2bf)

Summary

✅ 22 untouched benchmarks

tritao
tritao previously approved these changes Apr 11, 2025
Copy link
Contributor

@tritao tritao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

sdankel
sdankel previously approved these changes Apr 23, 2025
Copy link
Contributor

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

kayagokalp
kayagokalp previously approved these changes Apr 23, 2025
@JoshuaBatty JoshuaBatty dismissed stale reviews from kayagokalp and sdankel via 35cd155 April 23, 2025 22:07
@JoshuaBatty JoshuaBatty force-pushed the josh/lsp_workspace_bug branch from b603793 to 35cd155 Compare April 23, 2025 22:07
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) April 24, 2025 00:25
Copy link
Contributor

@zees-dev zees-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JoshuaBatty JoshuaBatty mentioned this pull request Apr 24, 2025
2 tasks
@JoshuaBatty JoshuaBatty merged commit b3322fb into master Apr 24, 2025
41 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/lsp_workspace_bug branch April 24, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language server LSP server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants