Skip to content

fix: add implicit-std = false to fix failing LSP test #7116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Apr 24, 2025

Description

The sync_with_updates_to_manifest_in_workspace test was failing because I forgot to specify implicit-std = false in the Forc.toml which meant it was trying to fetch when it shouldn't have.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested a review from a team as a code owner April 24, 2025 04:48
@JoshuaBatty JoshuaBatty changed the title add implicit-std = false to fix failing LSP test fix: add implicit-std = false to fix failing LSP test Apr 24, 2025
@JoshuaBatty JoshuaBatty changed the title fix: add implicit-std = false to fix failing LSP test fix: add implicit-std = false to fix failing LSP test Apr 24, 2025
@JoshuaBatty JoshuaBatty added the language server LSP server label Apr 24, 2025
@JoshuaBatty JoshuaBatty self-assigned this Apr 24, 2025
@JoshuaBatty JoshuaBatty requested a review from a team April 24, 2025 04:50
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Performance Report

Merging #7116 will not alter performance

Comparing josh/fix_test (e716007) with master (7e1bc15)

Summary

✅ 22 untouched benchmarks

@JoshuaBatty JoshuaBatty enabled auto-merge (squash) April 24, 2025 05:07
@JoshuaBatty JoshuaBatty merged commit d0aea90 into master Apr 24, 2025
41 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/fix_test branch April 24, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants