Skip to content

Add forc-publish to release binaries #7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 30, 2025
Merged

Conversation

sdankel
Copy link
Contributor

@sdankel sdankel commented Apr 29, 2025

Description

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp
Copy link
Member

kayagokalp commented Apr 29, 2025

We need to add the forc publish entry to the docs so that the plugin can generate it automatically, otherwise looks good to me.

@sdankel sdankel marked this pull request as ready for review April 29, 2025 23:51
@sdankel sdankel requested review from a team as code owners April 29, 2025 23:51
@kayagokalp kayagokalp requested a review from a team April 29, 2025 23:56
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) April 30, 2025 00:07
@JoshuaBatty JoshuaBatty requested a review from a team as a code owner April 30, 2025 00:36
@JoshuaBatty JoshuaBatty merged commit 7206479 into master Apr 30, 2025
43 checks passed
@JoshuaBatty JoshuaBatty deleted the sophie/forc-publish-bin branch April 30, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants