Skip to content

ci: Ensure that std-lib version matches forc version #7154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2025

Conversation

sdankel
Copy link
Contributor

@sdankel sdankel commented May 5, 2025

Description

Sway std library will be released when forc is released. To keep it simple, we'll ensure that the version of sway std matches the version of forc. This PR adds a CI step to enforce this.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel temporarily deployed to fuel-sway-bot May 5, 2025 20:33 — with GitHub Actions Inactive
@sdankel sdankel temporarily deployed to fuel-sway-bot May 5, 2025 20:42 — with GitHub Actions Inactive
@sdankel sdankel marked this pull request as ready for review May 5, 2025 20:46
@sdankel sdankel requested review from a team as code owners May 5, 2025 20:46
@sdankel sdankel requested a review from a team May 5, 2025 22:11
zees-dev
zees-dev previously approved these changes May 6, 2025
JoshuaBatty
JoshuaBatty previously approved these changes May 6, 2025
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step likely needs to be added to verification-complete or this will be purely informative and not enforced.

@sdankel sdankel dismissed stale reviews from JoshuaBatty and zees-dev via ba37034 May 6, 2025 20:29
@sdankel sdankel enabled auto-merge (squash) May 6, 2025 20:29
@sdankel sdankel temporarily deployed to fuel-sway-bot May 6, 2025 20:30 — with GitHub Actions Inactive
@JoshuaBatty JoshuaBatty requested review from a team May 6, 2025 23:49
@JoshuaBatty JoshuaBatty added the ci label May 6, 2025
@sdankel sdankel temporarily deployed to fuel-sway-bot May 7, 2025 21:44 — with GitHub Actions Inactive
@sdankel sdankel merged commit a37e3cd into master May 8, 2025
40 checks passed
@sdankel sdankel deleted the sophie/check-forc-manifest-version branch May 8, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants