-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Run forc-unit-tests
on CI in release
and debug
mode
#7159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+63
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdankel
previously approved these changes
May 6, 2025
zees-dev
reviewed
May 6, 2025
kayagokalp
previously approved these changes
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
JoshuaBatty
previously approved these changes
May 12, 2025
JoshuaBatty
approved these changes
May 13, 2025
zees-dev
reviewed
May 13, 2025
zees-dev
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
debug
torelease
.forc-unit-tests
CI step, to run the tests both indebug
andrelease
mode.By switching to
release
builds, we ensure that we test the versions that are actually released, unlike thedebug
version. As a consequence, execution time of CI steps gets shortened. The drawback is potentially not catching issues detectable only in thedebug
mode, like, e.g., overflows. We will add a separate CI workflow, running nightly or on tagged versions only, that will usedebug
builds as explained in #7168.Currently, we are running
forc-unit-tests
only in thedebug
mode. Compiler panics inin_language_tests
, described in #7157, that happens only inrelease
mode, shows that it is beneficial to run the unit test both indebug
andrelease
mode. Similar is with compiler panics described in #7161.The PR also removes the explicit
forc build
part from those tests and leaves only theforc test
part. The reasoning behind that change is, thatforc test
also builds the projects, indeed with tests included, but, since we currently don't support#[cfg(test)]
, otherwise unchanged. Runningforc build
in addition effectively doubles the test execution time, and the actual benefit in testing, compared to running onlyforc test
is, in best case, negligible.Checklist
Breaking*
orNew Feature
labels where relevant.