Skip to content

Remove AbiEncode impl for raw_ptr #7160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

tritao
Copy link
Contributor

@tritao tritao commented May 6, 2025

This was added originally in #6844 but should not have been introduced in the first place.

I added this while in development for the trait coherence feature but its not necessary and not something we wish to support in the public ABI surface.

Fixes #7153.

Thanks to @ironcev for catching this.

@tritao tritao self-assigned this May 6, 2025
@tritao tritao requested review from a team as code owners May 6, 2025 12:29
@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels May 6, 2025
This was added originally in FuelLabs#6844
but should not have been introduced in the first place.

I added this while in development for the trait coherence feature but
its not necessary and not something we wish to support in the public ABI
surface.

Fixes FuelLabs#7153.
@tritao tritao force-pushed the remove-rawptr-abiencode branch from be12396 to 765e269 Compare May 6, 2025 12:30
@tritao tritao temporarily deployed to fuel-sway-bot May 6, 2025 12:31 — with GitHub Actions Inactive
@IGI-111 IGI-111 requested a review from a team May 6, 2025 12:52
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot May 6, 2025 12:53 — with GitHub Actions Inactive
@tritao tritao enabled auto-merge (squash) May 6, 2025 12:53
@tritao tritao merged commit f635cc2 into FuelLabs:master May 6, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AbiEncode impl for raw_ptr
3 participants