-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Refactor: Move SyncWorkspace
from Session
into ServerState
#7166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6dabc8c
to
facf904
Compare
CodSpeed Performance ReportMerging #7166 will improve performances by 16.5%Comparing Summary
Benchmarks breakdown
|
49bc8cd
to
edda976
Compare
36fffad
to
614d331
Compare
b6e9708
to
0d3c1d9
Compare
Co-authored-by: zees-dev <[email protected]>
Co-authored-by: zees-dev <[email protected]>
Co-authored-by: zees-dev <[email protected]>
…to get cloned Arc<SyncWorkspace> from ServerState.
f8099e5
to
2b1f797
Compare
f3c5281
to
7219b01
Compare
sdankel
approved these changes
May 19, 2025
zees-dev
approved these changes
May 19, 2025
tritao
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SyncWorkspace
ownership from individualSession
instances to a single, global instance withinServerState
.SyncWorkspace
is now initialized once when the LSP server starts, creating a single temporary workspace clone.Also removes the
resync
function. This was causing the server and the IDE to fall out of sync with each other. For example, if you have 2 panels open and then save a file in one of the tabs but have unsaved changes in the other tab then those changes would not be reflected in the temp memory folder. This meant everything would be out of sync. We already are syncing everything on each keystroke per file so this fn was not necessary in the first place.This PR is a precursor to #7139
part of #7111
Checklist
Breaking*
orNew Feature
labels where relevant.