-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: use SSE in forc-publish for long-running uploads #7178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
reviewed
May 16, 2025
zees-dev
reviewed
May 17, 2025
zees-dev
reviewed
May 17, 2025
zees-dev
previously approved these changes
May 17, 2025
JoshuaBatty
approved these changes
May 19, 2025
zees-dev
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to enhance the functionality of the
forc-publish
plugin, including improvements to error handling, support for streaming server responses, and updates to dependencies. The most significant changes include adding a new error variant, updating theupload
method to handle streaming responses, and modifying dependencies to includefutures-util
and additional features forreqwest
.Enhancements to Error Handling:
ServerError
variant to theError
enum inforc-plugins/forc-publish/src/error.rs
to handle server-related errors.Improvements to
upload
Method:upload
method inforc-publish/src/forc_pub_client.rs
to process streaming server responses usingfutures-util::StreamExt
. This includes handling chunked data, parsing JSON responses, and printing event updates. [1] [2]Dependency Updates:
futures-util
as a dependency inCargo.toml
andforc-plugins/forc-publish/Cargo.toml
to support streaming operations. [1] [2]stream
feature forreqwest
inforc-plugins/forc-publish/Cargo.toml
to facilitate streaming server responses.Minor Adjustments:
println!
calls inmain.rs
to improve output formatting during error handling and publishing operations. [1] [2]