Skip to content

feat: add _ to powershell completion filename #20008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025
Merged

Conversation

daeho-ro
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Based on Homebrew/homebrew-core#224200, the powershell completion filename usually have _ prefix and so here I add it. There is no usage of :pwsh in the method generate_completions_from_executable, so we can change this without impact.

@p-linnane p-linnane added this pull request to the merge queue May 25, 2025
Merged via the queue into master with commit dc0f9d5 May 25, 2025
35 checks passed
@p-linnane p-linnane deleted the powershell-completion branch May 25, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants