Skip to content

split main and renderer db #8730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

split main and renderer db #8730

wants to merge 4 commits into from

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented May 19, 2025 •
edited
Loading

first step in nodeIntegration: false

  1. move nedb out of renderer
  2. move electron out of renderer
  3. ...lots more fun

github-advanced-security[bot]
github-advanced-security bot found potential problems May 19, 2025
View reviewed changes
packages/insomnia/src/main/database.ts

function getDBFilePath(modelType: string) {
// NOTE: Do not EVER change this. EVER!
return fsPath.join(process.env['INSOMNIA_DATA_PATH'] || electron.app.getPath('userData'), `insomnia.${modelType}.db`);

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal Warning

Detected possible user input going into a path.join or path.resolve function. This could possibly lead to a path traversal vulnerability, where the attacker can access arbitrary files stored in the file system. Instead, be sure to sanitize or validate user input first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jackkav