Skip to content

[Data] Ajout des zones réglementaires à data.gouv.fr #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Data] Ajout des zones réglementaires à data.gouv.fr #2284

wants to merge 3 commits into from

Conversation

maximeperraultdev
Copy link
Collaborator

Related Pull Requests & Issues

  • Tests flow prefect

@tristanrobert
Copy link
Contributor

tristanrobert commented May 20, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/2283/add_regulations_cacem_to_datagouv branch from 3322006 to 167f9fb Compare May 20, 2025 08:42
claire2212
claire2212 approved these changes May 20, 2025
View reviewed changes
datascience/config.py Outdated
REGULATIONS_DATASET_ID = "682ae3040ebe621687ec64ad"
REGULATIONS_CSV_RESOURCE_ID = "c9fe6865-602f-452c-ab31-e1d25222c158"
REGULATIONS_GEOPACKAGE_RESOURCE_ID = "TO DO"
REGULATIONS_CSV_RESOURCE_TITLE = "regulations_cacem.csv"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on pourrait changer regulations en regulatory_areas ou même un nom en français si ça correspond au nom du fichier que les personnes téléchargent

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, j'ai laissé pour l'instant. Alexia m'a dit qu'elle me ferait un retour sur les données qu'on veut envoyer au public.

datascience/src/pipeline/flows/regulatory_areas_open_data.py Outdated
"editeur",
"source",
"thematique",
"observation",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

est-ce qu'on est sûrs de vouloir rendre les observations accessibles à tous? Peut-être valider avec Pierre les champs qui sont partageables ? (je me pose aussi la question pour source)

@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/2283/add_regulations_cacem_to_datagouv branch 2 times, most recently from 252c71d to ee19643 Compare May 21, 2025 14:53
@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/2283/add_regulations_cacem_to_datagouv branch from ee19643 to 61a9440 Compare May 27, 2025 09:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claire2212 claire2212 claire2212 approved these changes

@VincentAntoine VincentAntoine VincentAntoine approved these changes

Assignees
No one assigned
Labels
data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data.gouv.fr] Ajouter les zones réglementaires
5 participants
@maximeperraultdev @tristanrobert @claire2212 @VincentAntoine @maximeperrault