Skip to content

基于 HSL 颜色转换的船新主题系统 #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2025
Merged

基于 HSL 颜色转换的船新主题系统 #720

merged 6 commits into from
May 31, 2025

Conversation

ruattd
Copy link

@ruattd ruattd commented May 29, 2025

使用基于 HSL 体系的颜色生成重写主题系统,让自定义主题功能更容易被造出来 为更自由的深色模式/色调设置提供可行性

目前深色配色有点问题,等后续改进

@ruattd ruattd added the 🚧 正在处理 开发者正在调查或处理该内容 label May 29, 2025
@ruattd ruattd marked this pull request as ready for review May 30, 2025 11:37
@ruattd
Copy link
Author

ruattd commented May 30, 2025

注1:这个 PR 基于 HSL 重写了配色系统,所以深色模式的天依蓝即 #66ccff 没有办法被完美复现出来了(实际上任何 RGB 颜色代码都不能被完美复现了),如果有需要请自行开一个分支修改 Color2 的值(虽然我觉得不会有人对颜色有这么精准的需求)

注2:这个 PR 只是重写配色系统,本身并不包含对深色模式 bug 的修复,有的 bug 已经被新的配色系统解决了,也有的 bug 还没有被解决

@ruattd ruattd added 🕑 等待合并 处理完毕,等待合并 and removed 🚧 正在处理 开发者正在调查或处理该内容 labels May 30, 2025
@ruattd ruattd requested a review from a team May 30, 2025 12:27
@tangge233 tangge233 added this to the 2.11.2 milestone May 30, 2025
Copy link

@Pigeon0v0 Pigeon0v0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以清理一下先前的代码,不用留着了大概

ruattd added 2 commits May 31, 2025 00:17
鬼知道这石山到底哪行代码用了 alpha 不为 0 的 ColorBrushTransparent
@ruattd
Copy link
Author

ruattd commented May 30, 2025

本来想改天另开个 PR 修这个问题,刚找到问题来源了索性一块修了

@Pigeon0v0
Copy link

配色调好了就能合了 大概吧

@tangge233
Copy link

没啥问题的话可以自己合了(

@wyc-26
Copy link

wyc-26 commented May 31, 2025

image
image
深色模式下有问题,暂时还不能合并

@ruattd
Copy link
Author

ruattd commented May 31, 2025

@wyc-26 pr message 里提到那个问题已经修了,还有别的 bug 吗

@ruattd
Copy link
Author

ruattd commented May 31, 2025

没有问题的话先合了,炸了再开 issue 吧

@ruattd ruattd merged commit 9569965 into dev May 31, 2025
4 checks passed
@PCL-Community-Bot PCL-Community-Bot added 👌 完成 处理完毕,将在下次更新后实装 and removed 🕑 等待合并 处理完毕,等待合并 labels May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👌 完成 处理完毕,将在下次更新后实装
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants