Sound test #3657
Merged
Sound test #3657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds comprehensive sound event testing, normalizes sound event emissions in the plugin, and provides example listeners.
- Introduce new end-to-end tests for sound effects, note blocks, and hardcoded sounds.
- Update the sound plugin to normalize names and emit both
soundEffectHeardandhardcodedSoundEffectHeard. - Provide example usage of sound event listeners in
examples/sound.js.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/externalTests/sound.js | Add tests for soundEffectHeard, noteHeard, and hardcodedSoundEffectHeard |
| lib/plugins/sound.js | Normalize sound names and emit compatible events |
| examples/sound.js | Add example listeners for sound events |
|
/makerelease |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.