Skip to content

feat: Security Logs Page #35218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Apr 11, 2025
Merged

feat: Security Logs Page #35218

merged 34 commits into from
Apr 11, 2025

Conversation

MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Feb 14, 2025

Requires #35258
Requires #35361

Proposed changes (including videos or screenshots)

Screenshot 2025-02-14 at 15 40 16 Screenshot 2025-02-14 at 15 41 05 Screenshot 2025-02-14 at 15 41 20 Screenshot 2025-02-14 at 17 25 09

Issue(s)

LOG-11

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Feb 14, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: f3cac5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/mock-providers Minor
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-voip Major
@rocket.chat/gazzodown Major
@rocket.chat/uikit-playground Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.50%. Comparing base (3e34228) to head (f3cac5f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #35218       +/-   ##
============================================
+ Coverage    59.62%   75.50%   +15.88%     
============================================
  Files         2832      533     -2299     
  Lines        68353    24091    -44262     
  Branches     15139     5750     -9389     
============================================
- Hits         40755    18190    -22565     
+ Misses       24992     5401    -19591     
+ Partials      2606      500     -2106     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review February 19, 2025 17:23
@MartinSchoeler MartinSchoeler requested review from a team as code owners February 19, 2025 17:23
Copy link
Contributor

github-actions bot commented Mar 12, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35218/

Built to branch gh-pages at 2025-04-11 16:54 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@MartinSchoeler MartinSchoeler added this to the 7.5.0 milestone Mar 18, 2025
@MartinSchoeler MartinSchoeler force-pushed the feat/Security-logs-FE branch 3 times, most recently from d4e7de6 to 390ed28 Compare March 18, 2025 19:16
@dougfabris dougfabris removed the request for review from a team March 20, 2025 02:42
@MartinSchoeler MartinSchoeler removed the request for review from a team March 20, 2025 03:00
@dougfabris dougfabris force-pushed the feat/Security-logs-FE branch from 6c3219e to 0689d7d Compare March 20, 2025 13:26
@MartinSchoeler MartinSchoeler modified the milestones: 7.5.0, 7.6.0 Mar 20, 2025
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translations

Setting_changed
Changed_from
Changed_to
Actor
Timestamp
Setting

Dates are being prepopulated here to the actual day, but the initial results are not filtered. This filter should probably be empty when accessing this Page. (Or at least filled with a value that represents the actual filter).
image

There's several style issues that I've encountered:

(Adittional comment in code) In the table, there's different heights depending on the type of record. From the design, all records have a height of 44px
Actor description for types that are not user should have their first letter capitalized.
image

In the modal, all the margins are different from the figma design. The color of the information (presented below the label) is the wrong collor (comment on code about InfoPanel component).
image

Also in the modal, if the setting is a big text (such as a custom script, or a license in the case of this example), the modal expands to the whole screen, and looks very weird. We should probably truncate this text a little bit, or limit the modal height and we can scroll the content.
image

Still in the modal, actors other than user are displaying the avatar.
image

There's also one thing that I didn't test, which is settings changed by an APP, but looking at the code, there's no information about what app made the changes. I'm also thinking that this information should somehow be in the table, but I'm not sure as it's not contemplated in the designs. We probably need to probe the design team on this. But I'm pretty sure we need to include at least the app ID somewhere, ideally the name.

@MartinSchoeler MartinSchoeler force-pushed the feat/Security-logs-FE branch 2 times, most recently from 12bdfa2 to 1bb309f Compare April 3, 2025 18:19
@MartinSchoeler MartinSchoeler force-pushed the feat/Security-logs-FE branch from f434366 to 05ef45c Compare April 10, 2025 16:34
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Apr 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2025
@MartinSchoeler MartinSchoeler dismissed stale reviews from dougfabris and yash-rajpal April 10, 2025 17:20

Stale

@kodiakhq kodiakhq bot merged commit 1eeb139 into develop Apr 11, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the feat/Security-logs-FE branch April 11, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants