feat: sync federated users from LDAP #35718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: dc2b23e The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35718 +/- ##
===========================================
- Coverage 59.62% 59.62% -0.01%
===========================================
Files 2832 2832
Lines 68352 68356 +4
Branches 15138 15155 +17
===========================================
Hits 40754 40754
- Misses 24992 24995 +3
- Partials 2606 2607 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
debdutdeb
previously approved these changes
Apr 9, 2025
Co-authored-by: Debdut Chakraborty <[email protected]>
debdutdeb
previously approved these changes
Apr 10, 2025
MarcosSpessatto
approved these changes
Apr 11, 2025
pierre-lehnen-rc
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR allows pre-registering federated users through the LDAP sync process, by loading the federation domain name from an LDAP attribute. If the specified attribute is missing or equal to the workspace's Home Server, the user will be created as a local user; If it's a different value, then the user will be created as a federated user.
With this, it's possible to display the display name and other profile information about remote users even before anyone talks to them using federation.
The federation domain will only be loaded on user creation. If an user is created as local, it can't be changed to a remote user. If it's a remote user, it can't be changed to local nor can its domain be changed.
Issue(s)
CORE-1072
Steps to test or reproduce
Further comments