-
Notifications
You must be signed in to change notification settings - Fork 11.8k
fix: await api startup to prevent apps-engine startup problems #35762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: await api startup to prevent apps-engine startup problems #35762
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 870ef14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35762 +/- ##
========================================
Coverage 59.62% 59.62%
========================================
Files 2832 2832
Lines 68356 68356
Branches 15141 15141
========================================
Hits 40754 40754
Misses 24995 24995
Partials 2607 2607
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
0474338
to
7349b75
Compare
7349b75
to
6565baa
Compare
Proposed changes (including videos or screenshots)
In local development running in microservices mode (yarn turbo run ms on project root), it seems that apps-engine tries to load the apps before the services are completely loaded, causing it to error 'apps-engine-not-initialized'
By awaiting the startup of the services, we guarantee that they're all already available when the apps begin to load
Issue(s)
CONN-615
Steps to test or reproduce
Further comments