Skip to content

fix: await api startup to prevent apps-engine startup problems #35762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Apr 10, 2025

Proposed changes (including videos or screenshots)

In local development running in microservices mode (yarn turbo run ms on project root), it seems that apps-engine tries to load the apps before the services are completely loaded, causing it to error 'apps-engine-not-initialized'

By awaiting the startup of the services, we guarantee that they're all already available when the apps begin to load

Issue(s)

CONN-615

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Apr 10, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 10, 2025

🦋 Changeset detected

Latest commit: 870ef14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 10, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35762/

Built to branch gh-pages at 2025-04-11 20:10 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.62%. Comparing base (a585b30) to head (870ef14).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35762   +/-   ##
========================================
  Coverage    59.62%   59.62%           
========================================
  Files         2832     2832           
  Lines        68356    68356           
  Branches     15141    15141           
========================================
  Hits         40754    40754           
  Misses       24995    24995           
  Partials      2607     2607           
Flag Coverage Δ
unit 75.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert force-pushed the fix/app-validation-microservice-inconsistency branch from 0474338 to 7349b75 Compare April 10, 2025 14:15
@d-gubert d-gubert force-pushed the fix/app-validation-microservice-inconsistency branch from 7349b75 to 6565baa Compare April 11, 2025 14:07
@d-gubert d-gubert added this to the 7.6.0 milestone Apr 11, 2025
@d-gubert d-gubert marked this pull request as ready for review April 11, 2025 15:01
@d-gubert d-gubert requested a review from sampaiodiego April 11, 2025 15:02
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Apr 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 11, 2025
@kodiakhq kodiakhq bot merged commit dd87ca9 into develop Apr 11, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/app-validation-microservice-inconsistency branch April 11, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants