Skip to content

feat: Draggable Voice/Video call popup #35830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
May 19, 2025
Merged

feat: Draggable Voice/Video call popup #35830

merged 54 commits into from
May 19, 2025

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Apr 16, 2025 •
edited
Loading

Proposed changes (including videos or screenshots)

This will be released as a feature preview.

Allows the call widget to be dragged on the screen.

All the logic related to positioning, transforms and events abastraction should be moved to fuselage and released as a separate package in the future.

Screen.Recording.2025-05-19.at.18.01.19.mov

Issue(s)

CORE-954

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 16, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a5bb519

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/gazzodown Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/uikit-playground Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kodus-ai Kodus AI
Copy link

kodus-ai bot commented Apr 16, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

kodus-ai[bot]
kodus-ai bot reviewed Apr 16, 2025
View reviewed changes
kodus-ai[bot]
kodus-ai bot reviewed Apr 16, 2025
View reviewed changes
kodus-ai[bot]
kodus-ai bot reviewed Apr 16, 2025
View reviewed changes
kodus-ai[bot]
kodus-ai bot reviewed Apr 16, 2025
View reviewed changes
kodus-ai[bot]
kodus-ai bot reviewed Apr 16, 2025
View reviewed changes
kodus-ai[bot]
kodus-ai bot reviewed Apr 16, 2025
View reviewed changes
@kodus-ai Kodus AI
Copy link

kodus-ai bot commented Apr 16, 2025 •
edited
Loading

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@codecov Codecov
Copy link

codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.51899% with 248 lines in your changes missing coverage. Please review.

Project coverage is 64.74%. Comparing base (4721074) to head (a5bb519).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35830      +/-   ##
===========================================
- Coverage    64.91%   64.74%   -0.17%     
===========================================
  Files         3098     3106       +8     
  Lines        92559    92877     +318     
  Branches     17652    17689      +37     
===========================================
+ Hits         60087    60137      +50     
- Misses       29708    29955     +247     
- Partials      2764     2785      +21
Flag Coverage Δ
e2e 58.40% <ø> (ø)
e2e-api 35.68% <ø> (+<0.01%) ⬆️
unit 71.68% <21.51%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kodus-ai Kodus AI
Copy link

kodus-ai bot commented Apr 17, 2025 •
edited
Loading

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@gabriellsh gabriellsh marked this pull request as ready for review April 17, 2025 18:00
@gabriellsh gabriellsh requested a review from a team as a code owner April 17, 2025 18:00
@kodus-ai Kodus AI
Copy link

kodus-ai bot commented Apr 17, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025 •
edited
Loading

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35830/

Built to branch gh-pages at 2025-05-19 21:10 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

cardoso
cardoso previously approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just one suggestion since I noticed locally and in CI: https://storybook.js.org/docs/configure/telemetry#how-to-opt-out

tassoevan
tassoevan reviewed May 19, 2025
View reviewed changes
@gabriellsh gabriellsh marked this pull request as ready for review May 19, 2025 20:44
@gabriellsh gabriellsh requested a review from a team as a code owner May 19, 2025 20:44
cardoso
cardoso previously approved these changes May 19, 2025
View reviewed changes
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label May 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 19, 2025
@kodiakhq kodiakhq bot merged commit aadc795 into develop May 19, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the feat/draggableVoipPopup branch May 19, 2025 22:13
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request May 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandernsilva aleksandernsilva aleksandernsilva left review comments

@kodus-ai kodus-ai[bot] kodus-ai[bot] left review comments

Copilot code review Copilot Copilot left review comments

@tassoevan tassoevan tassoevan approved these changes

@cardoso cardoso cardoso approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gabriellsh @tassoevan @cardoso @aleksandernsilva @scuciatto