Skip to content

LibJS: Save and restore exceptions on yields in finalizers #24244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Hendiadyoin1
Copy link
Contributor

Also removes a bunch of related old FIXMEs.


Test262:

    test/built-ins/AsyncGeneratorPrototype/throw/throw-suspendedYield-try-finally.js                       ❌ -> ✅
    test/built-ins/GeneratorPrototype/return/try-finally-nested-try-catch-within-inner-try.js              ❌ -> ✅
    test/built-ins/GeneratorPrototype/throw/try-finally-nested-try-catch-within-catch.js                   ❌ -> ✅
    test/built-ins/GeneratorPrototype/throw/try-finally-nested-try-catch-within-outer-try-after-nested.js  ❌ -> ✅
    test/built-ins/GeneratorPrototype/throw/try-finally-nested-try-catch-within-outer-try-before-nested.js ❌ -> ✅
    test/built-ins/GeneratorPrototype/throw/try-finally-within-try.js                                      ❌ -> ✅

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label May 6, 2024
Also removes a bunch of related old FIXMEs.
This makes the compilation backtraces a lot nicer, and allows clangd to
see the mistake as well.
@Hendiadyoin1 Hendiadyoin1 force-pushed the finally-(badum)-fix-the-last-finalizer-bug branch from 3c7dc8e to f9efcae Compare May 8, 2024 18:21
@awesomekling awesomekling merged commit e1aecff into SerenityOS:master May 8, 2024
12 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 8, 2024
@Hendiadyoin1 Hendiadyoin1 deleted the finally-(badum)-fix-the-last-finalizer-bug branch May 8, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants