update to slf4j 2 #3834
update to slf4j 2 #3834
Conversation
yannicklamprecht
force-pushed
the
update/slf4j-2
branch
from
3178c7a to
7be1a78
Compare
|
Can you please explain a bit more. Is this a breaking change? What was the historical reason we have slf4j again? It was for the maven resolver wasn't it? Doesn't that still use/depends on slf4j 1? |
|
The historic reason we have slf4j was the following: #3084 The slf4j 2 logging facade provides additional useful apis like the fluent way of logging. slf4j as a facade itself doesn't have a breaking change. The breaking change probably is how the factories and especially the bridges to the logger will be registered. In 1.x it was done using the logger factory binder interface, in 2.x it's via the Java service definition. As comparision to explain the absence of the old classes in the pull request. slf4j 1.7: https://github.com/qos-ch/slf4j/tree/1.7-maintenance/slf4j-jdk14/src/main/java/org/slf4j/impl |
I think this came about at least partially because the maven-resolver API brought in the slf4j API |
|
Also have you tested this with a slf4j using plugin? |
Yes, did a test using a plugin that utilizes slf4j 2 and a test with the same plugin using slf4j 1.7. Both work like expected. |
Ah okay. So your desire is to remove slf4j fully? That would be a breaking changes as plugins depend on slf4j being present. The whole slf4j update to 2.x will also help simplifying support for cross platform plugins which have bungee and spigot support in one jar, as spigot is using slf4j 2.x. Currently plugins supporting both platforms need to depend on slf4j 1.7 because otherwise they need to shade slf4j 2.x in their plugins. |
|
Wasn't aware spigot was using 2.x, that probably simplifies things |
No description provided.