Skip to content

feat(svelte): allow dynamic Store instance #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wobsoriano
Copy link
Contributor

@wobsoriano wobsoriano commented May 18, 2025

The useStore() function needs to be updated to accommodate dynamic Store instance values from @tanstack/db. See full discussion.

This PR already reruns the $effect callback when the Store instance changes but the .subscribe callback never gets invoked. Tbh not sure if this is optimal but I don't see an obvious better way of reacting to @tanstack/db's compiledQuery changes.

cc @crutchcorn

Copy link

nx-cloud bot commented May 18, 2025

View your CI Pipeline Execution ↗ for commit 826d8bf.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 31s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-18 19:59:24 UTC

Copy link

pkg-pr-new bot commented May 18, 2025

@tanstack/angular-store

npm i https://pkg.pr.new/@tanstack/angular-store@193

@tanstack/react-store

npm i https://pkg.pr.new/@tanstack/react-store@193

@tanstack/solid-store

npm i https://pkg.pr.new/@tanstack/solid-store@193

@tanstack/store

npm i https://pkg.pr.new/@tanstack/store@193

@tanstack/vue-store

npm i https://pkg.pr.new/@tanstack/vue-store@193

@tanstack/svelte-store

npm i https://pkg.pr.new/@tanstack/svelte-store@193

commit: 826d8bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant